Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Jul 19, 2025

  1. Added PreviewVideo to io
  2. All nodes were tested, all works nice
Screenshot from 2025-07-18 19-00-25

WAN nodes:

Screenshot from 2025-07-19 10-22-07 Screenshot from 2025-07-19 10-44-34 Screenshot from 2025-07-19 11-42-24

@bigcat88 bigcat88 changed the title [V3] SaveVide, LoadVideo, SaveWEBM [V3] SaveVide, LoadVideo, SaveWEBM, WAN nodes Jul 19, 2025
@bigcat88 bigcat88 force-pushed the v3/nodes/video-save branch from cc705ea to 9e37b54 Compare July 19, 2025 08:07
@bigcat88 bigcat88 changed the title [V3] SaveVide, LoadVideo, SaveWEBM, WAN nodes [V3] SaveVideo, LoadVideo, SaveWEBM, WAN nodes Jul 19, 2025
@Kosinkadink Kosinkadink added the v3 label Jul 20, 2025
@Kosinkadink
Copy link
Collaborator

Before merging this one, we should remove defining ids on outputs. Otherwise, looks good!

For the PreviewX classes, we'd want them to support passing in both the object that makes the 'X' (Tensor, batch of Tensors, etc), as well as the SavedResult. We'd also want to extract that functions that 'save' the 'X' on disk, so that we can reference that for Preview nodes with the temporary directory instead of duplicating the code. <- That is out of scope for this PR, but just wanted to note here that it will be worked on!

@Kosinkadink Kosinkadink merged commit 6a77eb1 into comfyanonymous:v3-definition Jul 22, 2025
2 checks passed
@bigcat88 bigcat88 deleted the v3/nodes/video-save branch July 23, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants