Content-Disposition headers

[Myestery]

Update Content-Disposition header to include 'inline' for image responses.

meant to fix #8914

Old Behaviour

As seen in the linked issue, when Content Disposition is fetched for an image using the view_image function, it is erroneous to parse as it doesn't follow RFC standard

New Behaviour

Standard RFC pattern for Content Disposition is used to render images inline in the browser ( 100% backwards compatible as this is the browser's default)

[jtydhr88]

hi @OrangeDoro, same to #8716, I suggest do not use working/reviewing PR for your study, it may be confuse for later core team reviewer.
Other than these, I suggest you choose draft PRs which put on hold, for example, you could use #8265 and Comfy-Org/ComfyUI_frontend#3976 which contain BE and FE changes, I am the owner of these two PRs

[kevinpaik1]

PR Review Summary

Status: ✅ Approved for Core Team Review

For the Contributor

Thank you for this clean fix to the Content-Disposition headers! Your PR properly addresses issue #8914 by making the headers RFC 6266 compliant. The implementation is minimal and correct - exactly what we want to see.

Technical Summary

• Scope: Updates Content-Disposition headers to include 'inline' directive
• Files Changed: 1 file (+4/-4 lines)
• Build Status: ✅ PASS
• Test Status: ✅ PASS (manual verification)
• Security: ✅ Clean
• Architecture: ✅ Aligned

Review Highlights

Strengths:

• Follows RFC 6266 standard correctly
• Minimal change that solves the specific issue
• Maintains full backward compatibility
• Good documentation with before/after evidence

Key Findings:

• The 'inline' directive is the browser default, so this change explicitly declares existing behavior
• No security implications as filename parameter is already validated
• Performance impact is negligible (7 bytes per response)

Remaining Items: None

Next Steps

This PR is ready for core team review. The core team will conduct their own evaluation and may request additional changes before merge.

For Core Team

Focus Areas: Standard review - RFC compliance verification
Review Complexity: Low - straightforward header format fix

[guill]

This seems like a good and safe fix.

[guill]

It looks like you may need to merge back from main (or rebase) to get the updates that allow you to pass the new Windows Line Endings CI. Apologies for the inconvenience.

[Myestery]

all done @guill

[kevinpaik1]

Thank you for your contribution @Myestery!