V3 update - Changed class cloning/locking, renames/typehint improvements #8900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Kosinkadink
commented
Jul 14, 2025
Kosinkadink
commented
- Changed class cloning and locking to be less restrictive towards class references
- Renamed prepare_class_clone to PREPARE_CLASS_CLONE for usage consistency (internal only)
- Made a wrapper around execute so that the output received is always a NodeOutput
- Small typehint improvement by adding ComfyTypeI for types that only have Input but no Output class
…n, Int, and Combos
…ECUTE_NORMALIZED to wrap around execute function so that a NodeOutput is always returned
Kosinkadink
requested review from
christian-byrne,
comfyanonymous,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.