V3 nodes: stable cascade #8872
Merged
V3 nodes: stable cascade #8872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigcat88
requested review from
Kosinkadink,
christian-byrne,
comfyanonymous,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
|
Looks good, merging |
Kosinkadink
merged commit a7e9956
into
comfyanonymous:v3-definition
2 of 3 checks passed
|
Why did you merge this? the tests were not passing. |
|
oh sorry I thought it was targetting master. |
|
can you please revert the revert-ion, or should I open the new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 nodes ported and tested.
StableCascade_SuperResolutionControlnetwas not tested, just ported, but it is very simple and should not produce errors.Notes:
I'm not sure why the following code was present in the V1 nodes, as no nodes were actually reading the
devicevalue:So, it was not ported.