Skip to content

Conversation

@blepping
Copy link
Contributor

@blepping blepping commented Oct 21, 2024

ComfyUI currently has a bug where disabling add_noise in samplers or using a DisableNoise node simply does not seed the RNG at all, resulting in non-deterministic generations. #4518 aims to fix that problem by actually seeding the RNG even when adding noise is disabled. this pull takes a slightly different approach: we throw an error when the user attempts to disable noise rather than proceeding anyway and erroneously ignoring the seed.

this pull could also be changed to simply remove the DisableNoise node and add_noise parameters but i thought it would be a bit more friendly to let people load existing workflows.

closes #2833

@catboxanon
Copy link
Contributor

This would break compatibility with https://github.com/BlenderNeko/ComfyUI_Noise. I'm sure your intent with this PR is just to get something merged at all to avoid this bug though, which should've have had the fix merged months ago by now.

@blepping
Copy link
Contributor Author

This would break compatibility with https://github.com/BlenderNeko/ComfyUI_Noise.

and my own nodes also.

I'm sure your intent with this PR is just to get something merged at all to avoid this bug though

eh, i knew from the beginning there was no chance of it getting merged. it's not really serious, but i genuinely think merging it would be better than the status quo where disabling add_noise in the built-in samplers is just silently broken.

at least just preventing the ability to disable add_noise would push people toward using sampler nodes that actually work reliably.

@blepping blepping closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No seed gets set in custom/advanced samplers when add_noise is disabled

2 participants