Increase maximum macOS version to 15.0.1 when forcing upcast attention #5191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comfyanonymous
added
the
Run-CI-Test
|
(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=5191%2Fmerge |
|
I'm glad to see this updated for MacOS 15, but it's unfortunately already out of date. I'm running 15.1 and getting black output. Would it make sense to assume this behavior until next major version (i.e. |
|
I assume they are going to fix it at some point so I'll just keep bumping the version up until they do. |
|
🫡 Thank you for your service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the latest version of macOS (15.0.1), the
--force-upcast-attentionflag is required to fix a "black image" bug (#3521). Similar to #4548, this PR checks whether the macOS version is affected and automatically forces upcast attention.