Add Batch Size Argument for EmptyLatentAudio and WAV File Format Option for SaveAudio #4721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding batch size is good but I think the wav saving should be a different node because different file formats can have different options. |
mcmonkey4eva
reviewed
Sep 9, 2024
| torchaudio.save(buff, waveform, audio["sample_rate"], format=file_format) | ||
|
|
||
| buff = insert_or_replace_vorbis_comment(buff, metadata) | ||
| if (file_format == "flac"): |
There was a problem hiding this comment.
python code shouldn't have () parens here
|
Could you please separate the two parts of this PR into two separate PRs? |
mcmonkey4eva
added
User Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request introduces two new features for the audio tools:
Batch Size Argument for
EmptyLatentAudio:This feature allows users to specify the batch size when creating empty latent audio with the
EmptyLatentAudionode. Can be used for making one-shot (drum) samples.WAV File Format Option for
SaveAudio:A new option to save audio files in WAV format has been added to the
SaveAudionode. This change enables users to save audio files in the widely used WAV format, making integration with other audio tools easier, instead of relying only on FLAC.Changes
batch_sizeargument to theEmptyLatentAudionode.SaveAudionode to support saving audio files in WAV format.Benefits
Improved flexibility and scalability:
The batch size argument allows users to create larger batch sizes to be used to create one-shot samples or more variations.
Broader file format support:
The WAV format is commonly used in many audio processing workflows and has better support in DAWs. Adding support for it helps increase compatibility with various applications and use cases.
Testing
Please review and let me know if any additional changes are needed. Thank you!