Add denoise percentage to BetaSamplingScheduler node #4558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
reviewed
Sep 9, 2024
comfy_extras/nodes_custom_sampler.py
Outdated
| "steps": ("INT", {"default": 20, "min": 1, "max": 10000}), | ||
| "alpha": ("FLOAT", {"default": 0.6, "min": 0.0, "max": 50.0, "step":0.01, "round": False}), | ||
| "beta": ("FLOAT", {"default": 0.6, "min": 0.0, "max": 50.0, "step":0.01, "round": False}), | ||
| "steps": ("INT", {"default": 20, "min": 1, "max": 10000}), |
There was a problem hiding this comment.
moving steps like this is a workflow-breaking change
|
I believe the preferred method here is to use the split sigmas nodes iirc? |
mcmonkey4eva
added
User Support
RandomGitUser321
force-pushed
the
master
branch
from
f06f1d5 to
e7d4782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realistically, this should be added to all these nodes, I just happened to need it for this specific node at the moment.
Here's 1:1 parity proof vs the regular BasicScheduler node:
