Some minor code tweaks #4303
Some minor code tweaks #4303
Conversation
"global folder_names_and_paths" is missing in get_folder_paths
Cleanup unnecessary & unused helper functions
|
I also cleaned up some helper functions that either weren't used at all or are pretty useless. |
Remove unused default reference
Missed one occurance of "exists"
double negative -> positive
Fix bug when model cannot be partially unloaded.
folder_paths.py
Outdated
| folder_names_and_paths[folder_name] = ([full_folder_path], set()) | ||
|
|
||
| def get_folder_paths(folder_name: str) -> list[str]: | ||
| global folder_names_and_paths |
There was a problem hiding this comment.
mcmonkey4eva
added
User Support
comfy/gligen.py
Outdated
| inner_dim = int(dim * mult) | ||
| dim_out = default(dim_out, dim) | ||
| if not dim_out: | ||
| dim_out = dim() if isfunction(dim) else dim |
There was a problem hiding this comment.
dim is definitely not a function here
mcmonkey4eva
added
the
Good PR
|
oh, right, I can just edit PRs to make minor adjustments, nice |
mcmonkey4eva
added
the
Run-CI-Test
|
(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=4303%2Fmerge |
mcmonkey4eva
removed
the
Run-CI-Test
|
Comfy looked this over and did some testing, and found a bug that didn't surface in my own testing and attempts to cleanup (openaimodel line 649 edit is wrong), and after some discussion we reached the conclusion that this type of broad large alteration should not come from an external PR, or if you do send a PR it should be one file at a time, and very thoroughly validated. |
3 participants
global folder_names_and_pathsis missing inget_folder_paths