Skip to content

Conversation

@bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 29, 2025

  1. Removed the old, unnecessary upload_file_to_comfyapi function. All nodes now use its new implementation.
  2. Migrated Luma API nodes to the new API client and removed unused code (e.g., IO.Hidden.auth_token_comfy_org in non-API nodes).
  3. Migrated Minimax nodes to the new API client. Also fixed backup_download_url handling: the node now makes two attempts to download from the China-based download_url; if both fail, it makes up to three attempts using the US-based backup_download_url.
  4. Continuing to split Pydantic models into separate files. Rationale: the single backend-generated file is hard to update and sometimes uses hard-to-read names. Making a PR to backend to update some small value is hardly an option. Most nodes already use separate files for Pydantic models, and this change continues that direction. Additionally we may consider moving validation of inputs to Pydantic models with nice human readable error messages, once Pydantic reach amazing v3 on which they are working now.

Everything was tested, to ensure that nothing got broken:

Screenshot From 2025-10-28 08-55-14 Screenshot From 2025-10-28 10-28-07

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 29, 2025 06:24
@bigcat88
Copy link
Contributor Author

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 29, 2025
Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, merging

@Kosinkadink Kosinkadink merged commit 6c14f3a into comfyanonymous:master Oct 29, 2025
12 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/minimax-luma-new-api-client branch October 31, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants