Skip to content

Conversation

bigcat88
Copy link
Contributor

  1. Add price_extractor for the API nodes where we can not calculate price in advance. Currently it is displayed in the "status" text - in future we can make minor changes and perhaps allow updating Price Badge from the Node.
  2. Change most of PollingOperation args to be kwargs as new changes will be made in upcoming PR(we already use everywhere only kwargs when using it) - just to be safe.
  3. Add check for PikaStartEndFrameNode node to disallow empty prompts(error 422 from their API).
  4. Fixed a single output bug (video_id was output instead of duration) in the KlingDualCharacterVideoEffectNode node, which was detected by the (now working) type checker.
Screenshot From 2025-10-10 09-52-37

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 10, 2025 06:57
@bigcat88
Copy link
Contributor Author

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 10, 2025
@Kosinkadink
Copy link
Collaborator

Kosinkadink commented Oct 10, 2025

For the pricing, we should format it as $#.## instead of as #.#$

@Kosinkadink
Copy link
Collaborator

Other than that though, looks good and I'll merge as soon as that gets changed!

Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since that's so minor, I'll merge it in now, and then a separate PR can fix it.

@Kosinkadink Kosinkadink merged commit 14d642a into comfyanonymous:master Oct 10, 2025
12 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/dynamic-pricing branch October 11, 2025 04:52
toxicwind pushed a commit to toxicwind/ComfyUI that referenced this pull request Oct 12, 2025
gmaOCR pushed a commit to gmaOCR/ComfyUI that referenced this pull request Oct 14, 2025
adlerfaulkner pushed a commit to LucaLabsInc/ComfyUI that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants