fix(ReCraft-API-node): allow custom multipart parser to return FormData #10244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up the bug found during developing new pylint rules: #10213
Currently all ReCraft nodes that accepts at the same time
input file
andRecRaft Control
broken.This happened cause
aiohttp
library does not expands list values indata=
into repeated form fields, e.g.:The switch to
aiohttp
(to make node async) broke those nodes, causeaihttp
serializes them as strings:To prevent the fix from affecting all nodes again, I propose simply extending the current feature of custom
multipart_parser
and allowing it to returnFormData
instead ofdict
.This way, the fix only touches the custom multipart_parser of ReCraft API nodes and does not affect any other API nodes.
Before this PR:
After this PR: