Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 7, 2025

Follow up the bug found during developing new pylint rules: #10213

Currently all ReCraft nodes that accepts at the same time input file and RecRaft Control broken.

This happened cause aiohttp library does not expands list values in data= into repeated form fields, e.g.:

controls[colors][][rgb][]=40
controls[colors][][rgb][]=12
controls[colors][][rgb][]=3

The switch to aiohttp (to make node async) broke those nodes, cause aihttp serializes them as strings:

controls[colors][][rgb][]= "[40, 12, 3]"

To prevent the fix from affecting all nodes again, I propose simply extending the current feature of custom multipart_parser and allowing it to return FormData instead of dict.

This way, the fix only touches the custom multipart_parser of ReCraft API nodes and does not affect any other API nodes.

Before this PR:

Screenshot From 2025-10-07 09-11-39

After this PR:

Screenshot From 2025-10-07 09-12-25

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 7, 2025 06:22
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 7, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 7, 2025
Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, merging

@Kosinkadink Kosinkadink merged commit fc34c3d into comfyanonymous:master Oct 7, 2025
12 checks passed
@bigcat88 bigcat88 deleted the fix/api-nodes/recraft-multipart branch October 8, 2025 06:23
toxicwind pushed a commit to toxicwind/ComfyUI that referenced this pull request Oct 12, 2025
gmaOCR pushed a commit to gmaOCR/ComfyUI that referenced this pull request Oct 14, 2025
adlerfaulkner pushed a commit to LucaLabsInc/ComfyUI that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants