[V3] convert nodes_custom_sampler.py to V3 schema #10206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+label: Core |
Kosinkadink
changed the title
|
Since this changes so many nodes + a lot of custom nodes affected at the same time, we should give 2 weeks heads up to custom nodes, and use that time for QA. We just need to make sure every node gets tested from this. |
Should I test every node from this PR? |
|
Yep, ideally every node should be tested. |
bigcat88
force-pushed
the
v3/nodes_custom_sampler
branch
from
23066aa to
2177439
Compare
done, all nodes are good. |
This was referenced Oct 13, 2025
|
Node authors notified, will merge on Wednesday October 29th. |
Kosinkadink
added
the
Scheduled Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many nodes from this PR were tested. During conversion, minimal possible changes were made to avoid breaking such a large file.
Objects git diff:
object_info_difference.zip