Skip to content

[V3] convert nodes_rodin.py to V3 schema #10195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

[V3] convert nodes_rodin.py to V3 schema #10195

merged 1 commit into from
Oct 4, 2025

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 4, 2025

As usual nodes were tested after conversion:

Screenshot From 2025-10-04 10-00-58

Note: The git diff code in the web interface is a bit confusing because all these nodes use parent inheritance, which I've moved into separate functions. Local git diff using Visual Studio or PyCharm looks much better. I didn't change the logic or anything else - just converted it to V3 to reduce the likelihood of errors.

Object git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index 2b7d3c6..e298a14 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -38627,7 +38627,9 @@
             "required": {
                 "Images": [
                     "IMAGE",
-                    {}
+                    {
+                        "forceInput": true
+                    }
                 ]
             },
             "optional": {
@@ -38643,36 +38645,30 @@
                 "Material_Type": [
                     "COMBO",
                     {
-                        "default": "PBR",
-                        "multiselect": false,
                         "options": [
                             "PBR",
                             "Shaded"
-                        ]
+                        ],
+                        "default": "PBR"
                     }
                 ],
                 "Polygon_count": [
                     "COMBO",
                     {
-                        "default": "18K-Quad",
-                        "multiselect": false,
                         "options": [
                             "4K-Quad",
                             "8K-Quad",
                             "18K-Quad",
                             "50K-Quad",
                             "200K-Triangle"
-                        ]
+                        ],
+                        "default": "18K-Quad"
                     }
                 ]
             },
             "hidden": {
-                "auth_token_comfy_org": [
-                    "AUTH_TOKEN_COMFY_ORG"
-                ],
-                "api_key_comfy_org": [
-                    "API_KEY_COMFY_ORG"
-                ]
+                "auth_token": "AUTH_TOKEN_COMFY_ORG",
+                "comfy_api_key": "API_KEY_COMFY_ORG"
             }
         },
         "input_order": {
@@ -38685,8 +38681,8 @@
                 "Polygon_count"
             ],
             "hidden": [
-                "auth_token_comfy_org",
-                "api_key_comfy_org"
+                "auth_token",
+                "comfy_api_key"
             ]
         },
         "output": [
@@ -38698,17 +38694,12 @@
         "output_name": [
             "3D Model Path"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Rodin3D_Regular",
         "display_name": "Rodin 3D Generate - Regular Generate",
         "description": "Generate 3D Assets using Rodin API",
         "python_module": "comfy_api_nodes.nodes_rodin",
         "category": "api node/3d/Rodin",
         "output_node": false,
-        "deprecated": false,
-        "experimental": false,
         "api_node": true
     },
     "Rodin3D_Detail": {
@@ -38716,7 +38707,9 @@
             "required": {
                 "Images": [
                     "IMAGE",
-                    {}
+                    {
+                        "forceInput": true
+                    }
                 ]
             },
             "optional": {
@@ -38732,36 +38725,30 @@
                 "Material_Type": [
                     "COMBO",
                     {
-                        "default": "PBR",
-                        "multiselect": false,
                         "options": [
                             "PBR",
                             "Shaded"
-                        ]
+                        ],
+                        "default": "PBR"
                     }
                 ],
                 "Polygon_count": [
                     "COMBO",
                     {
-                        "default": "18K-Quad",
-                        "multiselect": false,
                         "options": [
                             "4K-Quad",
                             "8K-Quad",
                             "18K-Quad",
                             "50K-Quad",
                             "200K-Triangle"
-                        ]
+                        ],
+                        "default": "18K-Quad"
                     }
                 ]
             },
             "hidden": {
-                "auth_token_comfy_org": [
-                    "AUTH_TOKEN_COMFY_ORG"
-                ],
-                "api_key_comfy_org": [
-                    "API_KEY_COMFY_ORG"
-                ]
+                "auth_token": "AUTH_TOKEN_COMFY_ORG",
+                "comfy_api_key": "API_KEY_COMFY_ORG"
             }
         },
         "input_order": {
@@ -38774,8 +38761,8 @@
                 "Polygon_count"
             ],
             "hidden": [
-                "auth_token_comfy_org",
-                "api_key_comfy_org"
+                "auth_token",
+                "comfy_api_key"
             ]
         },
         "output": [
@@ -38787,17 +38774,12 @@
         "output_name": [
             "3D Model Path"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Rodin3D_Detail",
         "display_name": "Rodin 3D Generate - Detail Generate",
         "description": "Generate 3D Assets using Rodin API",
         "python_module": "comfy_api_nodes.nodes_rodin",
         "category": "api node/3d/Rodin",
         "output_node": false,
-        "deprecated": false,
-        "experimental": false,
         "api_node": true
     },
     "Rodin3D_Smooth": {
@@ -38805,7 +38787,9 @@
             "required": {
                 "Images": [
                     "IMAGE",
-                    {}
+                    {
+                        "forceInput": true
+                    }
                 ]
             },
             "optional": {
@@ -38821,36 +38805,30 @@
                 "Material_Type": [
                     "COMBO",
                     {
-                        "default": "PBR",
-                        "multiselect": false,
                         "options": [
                             "PBR",
                             "Shaded"
-                        ]
+                        ],
+                        "default": "PBR"
                     }
                 ],
                 "Polygon_count": [
                     "COMBO",
                     {
-                        "default": "18K-Quad",
-                        "multiselect": false,
                         "options": [
                             "4K-Quad",
                             "8K-Quad",
                             "18K-Quad",
                             "50K-Quad",
                             "200K-Triangle"
-                        ]
+                        ],
+                        "default": "18K-Quad"
                     }
                 ]
             },
             "hidden": {
-                "auth_token_comfy_org": [
-                    "AUTH_TOKEN_COMFY_ORG"
-                ],
-                "api_key_comfy_org": [
-                    "API_KEY_COMFY_ORG"
-                ]
+                "auth_token": "AUTH_TOKEN_COMFY_ORG",
+                "comfy_api_key": "API_KEY_COMFY_ORG"
             }
         },
         "input_order": {
@@ -38863,8 +38841,8 @@
                 "Polygon_count"
             ],
             "hidden": [
-                "auth_token_comfy_org",
-                "api_key_comfy_org"
+                "auth_token",
+                "comfy_api_key"
             ]
         },
         "output": [
@@ -38876,17 +38854,12 @@
         "output_name": [
             "3D Model Path"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Rodin3D_Smooth",
         "display_name": "Rodin 3D Generate - Smooth Generate",
         "description": "Generate 3D Assets using Rodin API",
         "python_module": "comfy_api_nodes.nodes_rodin",
         "category": "api node/3d/Rodin",
         "output_node": false,
-        "deprecated": false,
-        "experimental": false,
         "api_node": true
     },
     "Rodin3D_Sketch": {
@@ -38894,7 +38867,9 @@
             "required": {
                 "Images": [
                     "IMAGE",
-                    {}
+                    {
+                        "forceInput": true
+                    }
                 ]
             },
             "optional": {
@@ -38909,12 +38884,8 @@
                 ]
             },
             "hidden": {
-                "auth_token_comfy_org": [
-                    "AUTH_TOKEN_COMFY_ORG"
-                ],
-                "api_key_comfy_org": [
-                    "API_KEY_COMFY_ORG"
-                ]
+                "auth_token": "AUTH_TOKEN_COMFY_ORG",
+                "comfy_api_key": "API_KEY_COMFY_ORG"
             }
         },
         "input_order": {
@@ -38925,8 +38896,8 @@
                 "Seed"
             ],
             "hidden": [
-                "auth_token_comfy_org",
-                "api_key_comfy_org"
+                "auth_token",
+                "comfy_api_key"
             ]
         },
         "output": [
@@ -38938,17 +38909,12 @@
         "output_name": [
             "3D Model Path"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Rodin3D_Sketch",
         "display_name": "Rodin 3D Generate - Sketch Generate",
         "description": "Generate 3D Assets using Rodin API",
         "python_module": "comfy_api_nodes.nodes_rodin",
         "category": "api node/3d/Rodin",
         "output_node": false,
-        "deprecated": false,
-        "experimental": false,
         "api_node": true
     },
     "Rodin3D_Gen2": {
@@ -38956,12 +38922,8 @@
             "required": {
                 "Images": [
                     "IMAGE",
-                    {}
-                ],
-                "TAPose": [
-                    "BOOLEAN",
                     {
-                        "default": false
+                        "forceInput": true
                     }
                 ]
             },
@@ -38978,19 +38940,16 @@
                 "Material_Type": [
                     "COMBO",
                     {
-                        "default": "PBR",
-                        "multiselect": false,
                         "options": [
                             "PBR",
                             "Shaded"
-                        ]
+                        ],
+                        "default": "PBR"
                     }
                 ],
                 "Polygon_count": [
                     "COMBO",
                     {
-                        "default": "500K-Triangle",
-                        "multiselect": false,
                         "options": [
                             "4K-Quad",
                             "8K-Quad",
@@ -39000,32 +38959,35 @@
                             "20K-Triangle",
                             "150K-Triangle",
                             "500K-Triangle"
-                        ]
+                        ],
+                        "default": "500K-Triangle"
+                    }
+                ],
+                "TAPose": [
+                    "BOOLEAN",
+                    {
+                        "default": false
                     }
                 ]
             },
             "hidden": {
-                "auth_token_comfy_org": [
-                    "AUTH_TOKEN_COMFY_ORG"
-                ],
-                "api_key_comfy_org": [
-                    "API_KEY_COMFY_ORG"
-                ]
+                "auth_token": "AUTH_TOKEN_COMFY_ORG",
+                "comfy_api_key": "API_KEY_COMFY_ORG"
             }
         },
         "input_order": {
             "required": [
-                "Images",
-                "TAPose"
+                "Images"
             ],
             "optional": [
                 "Seed",
                 "Material_Type",
-                "Polygon_count"
+                "Polygon_count",
+                "TAPose"
             ],
             "hidden": [
-                "auth_token_comfy_org",
-                "api_key_comfy_org"
+                "auth_token",
+                "comfy_api_key"
             ]
         },
         "output": [
@@ -39037,17 +38999,12 @@
         "output_name": [
             "3D Model Path"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Rodin3D_Gen2",
         "display_name": "Rodin 3D Generate - Gen-2 Generate",
         "description": "Generate 3D Assets using Rodin API",
         "python_module": "comfy_api_nodes.nodes_rodin",
         "category": "api node/3d/Rodin",
         "output_node": false,
-        "deprecated": false,
-        "experimental": false,
         "api_node": true
     },
     "GeminiNode": {

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 4, 2025 07:07
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 4, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 4, 2025
Kosinkadink
Kosinkadink approved these changes Oct 4, 2025
View reviewed changes
Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object_info diff looks good, merging.

@Kosinkadink Kosinkadink merged commit 2ed74f7 into comfyanonymous:master Oct 4, 2025
12 checks passed
@ramon7879 ramon7879 mentioned this pull request Oct 5, 2025
Closed
1 task
@bigcat88 bigcat88 deleted the v3/nodes_rodin branch October 9, 2025 16:00
toxicwind pushed a commit to toxicwind/ComfyUI that referenced this pull request Oct 12, 2025
@bigcat88
convert nodes_rodin.py to V3 schema (comfyanonymous#10195)
ac393fa
gmaOCR pushed a commit to gmaOCR/ComfyUI that referenced this pull request Oct 14, 2025
@bigcat88 @gmaOCR
convert nodes_rodin.py to V3 schema (comfyanonymous#10195)
b45697b
adlerfaulkner pushed a commit to LucaLabsInc/ComfyUI that referenced this pull request Oct 16, 2025
@bigcat88 @adlerfaulkner
convert nodes_rodin.py to V3 schema (comfyanonymous#10195)
95ed79c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kosinkadink Kosinkadink Kosinkadink approved these changes

Assignees

No one assigned

Labels

Core Core team dependency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigcat88 @Kosinkadink @comfy-pr-bot