Skip to content

feat: add link support for discussion #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

@vercel
Copy link

vercel bot commented Aug 1, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @colinlienard on Vercel.

@colinlienard first needs to authorize it.

Copy link
Owner

@colinlienard colinlienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!
It might be great to also show the comment and name of the persons who commented, I could do it in another pr

@bxb100
Copy link
Contributor Author

bxb100 commented Aug 2, 2023

Thks review, I can do it in this PR, so give me some time

@colinlienard colinlienard self-requested a review August 2, 2023 18:27
@bxb100
Copy link
Contributor Author

bxb100 commented Aug 3, 2023

done @colinlienard

Copy link
Owner

@colinlienard colinlienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot again for your work!

@@ -72,6 +72,7 @@
.description {
@include typography.base;

hyphens: auto;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, didn't know that was a thing

@colinlienard colinlienard merged commit af0b35e into colinlienard:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants