Skip to content

Conversation

@silmin
Copy link

@silmin silmin commented Dec 3, 2025

What changed? Why?
Resolved #2512
On the miniapp registration page on base.dev, you’re required to add baseBuilders.ownerAddress to manifest.json, but it’s being omitted by withValidManifest().
basedev_registerminiapp

Added baseBuilder field support to MiniAppManifest.

  • Added new BaseBuilderFields type with ownerAddress as a required field
  • Implemented baseBuilder validation in withValidManifest function
    • Only includes baseBuilder in manifest when ownerAddress is present
    • Logs a warning and omits from manifest when invalid

Notes to reviewers
Follows the same validation pattern as accountAssociation. When baseBuilder is provided but ownerAddress is empty/undefined, it logs a warning and omits from the manifest.

How has it been tested?
Added unit tests for baseBuilder handling:

  • Verifies omission when ownerAddress is undefined/empty string
  • Verifies no warning when baseBuilder is not provided
  • Verifies inclusion when valid ownerAddress is present
  • Verifies accountAssociation and baseBuilder can coexist

@vercel
Copy link

vercel bot commented Dec 3, 2025

@silmin is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Add baseBuilder property in MiniAppManifest type and let it include in withValidManifest

2 participants