Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add nil check to block asserter #510

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: add nil check to block asserter #510

merged 1 commit into from
Nov 25, 2024

Conversation

potterbm-cb
Copy link
Contributor

Motivation

Configuring a generic Asserter without a genesis block results in a nil pointer exception on this line.

Solution

Add a nil check

@cb-heimdall
Copy link

cb-heimdall commented Nov 25, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@potterbm-cb potterbm-cb merged commit 945092d into master Nov 25, 2024
11 checks passed
@potterbm-cb potterbm-cb deleted the bryan/fix-nil-pointer-exception branch November 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaying-peng xiaying-peng xiaying-peng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potterbm-cb @cb-heimdall @xiaying-peng