[REF] Change interfaces using tapeId to reference of tape#178
Open
TimSiebert1 wants to merge 3 commits intomasterfrom
Open
[REF] Change interfaces using tapeId to reference of tape#178TimSiebert1 wants to merge 3 commits intomasterfrom
TimSiebert1 wants to merge 3 commits intomasterfrom
Conversation
3e7e012 to
b559777
Compare
This PR changes the methods that rely on tapeId to select a tape from a global buffer to use a reference to the tape directly. The tape_interface methods are adapted accordingly and the global tapeBuffer is removed.
b559777 to
3905627
Compare
Contributor
|
That's pretty radical. It was thinking that this change can be made in a backward-compatible way:
Also, I am not convinced that suffixing everything with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the methods that rely on tapeId to select a tape from a global buffer to use a reference to the tape directly. The tape_interface methods are adapted accordingly and the global tapeBuffer is removed.
As proposed and discussed with @osander1