-
Notifications
You must be signed in to change notification settings - Fork 17
Add pending changelog for unreleased changes #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joeyparis
wants to merge
16
commits into
codus:master
Choose a base branch
from
joeyparis:pending-changelog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b31a1bb
Update runtime dependency thor to newer version
JoeyLeadJig d3ae1e2
Update changelog
JoeyLeadJig 1317b1c
Add pending changelog for unreleased changes
JoeyLeadJig 7504379
Update README.md
JoeyLeadJig 9897836
Prepend pending changes to CHANGELOG.md instead of creating separate …
JoeyLeadJig 56e3c9f
Merge branch 'master' into pending-changelog
JoeyLeadJig f91ade2
Merge branch 'master' into pending-changelog
joeyparis 48eb8c9
Update README and codelog.yml config
JoeyLeadJig 5cb55bd
Merge branch 'pending-changelog' of https://github.com/joeyparis/code…
JoeyLeadJig c09b76d
Fix rubocop offenses
JoeyLeadJig 6fd8fdc
Add additional regenerate rspec test
JoeyLeadJig 39d476d
Add regenerate rspec test to cli tests
JoeyLeadJig 1024178
Update spec/codelog/command/pending_spec.rb
joeyparis abcf77a
Fix issue where pending changes would still be included/duplicated as…
JoeyLeadJig fce993b
Merge branch 'codus:master' into pending-changelog
joeyparis 1f7ab94
Update pending changelog and Ruby tooling
JoeyLeadJig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ## Pending Changes | ||
| ### Added | ||
| - Ability to include pending changes in changelog for unreleased changes | ||
| - Test for the release preview flag | ||
|
|
||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| "Changed": | ||
| - Change thor runtime dependency to ~> 1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| "Added": | ||
| - Ability to include pending changes in changelog for unreleased changes | ||
| - Test for the release preview flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| module Codelog | ||
| module Command | ||
| class Pending | ||
| RELEASES_PATH = 'changelogs/releases'.freeze | ||
|
|
||
| def self.run(title) | ||
| Codelog::Command::Pending.new.run title | ||
| end | ||
|
|
||
| def run(title) | ||
| outputter = Codelog::Output::ReleaseFile.new("#{RELEASES_PATH}/pending.md") | ||
| Codelog::Command::Step::Version.run title, | ||
| Date.today.strftime(Codelog::Config.date_input_format), | ||
| outputter | ||
| Codelog::Command::Step::Changelog.run | ||
| puts "\n== Pending changes added to changelog ==" | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| require 'spec_helper' | ||
|
|
||
| describe Codelog::Command::Pending do | ||
| describe '#run' do | ||
| let(:mock_file_outputter) { double(Codelog::Output::ReleaseFile) } | ||
|
|
||
| it 'adds the pending changes to the changelog' do | ||
| allow(Codelog::Command::Step::Version).to receive(:new) | ||
| allow(Codelog::Output::ReleaseFile).to receive(:new).and_return(mock_file_outputter) | ||
|
|
||
| expect(Codelog::Command::Step::Version).to receive(:run).with('Pending Changes', Date.today.strftime(Codelog::Config.date_input_format), mock_file_outputter) | ||
| expect(Codelog::Command::Step::Changelog).to receive(:run) | ||
| expect(subject).to receive(:puts).with("\n== Pending changes added to changelog ==") | ||
| subject.run 'Pending Changes' | ||
| end | ||
| end | ||
|
|
||
| describe '.run' do | ||
| it 'creates an instance of the class to run the command' do | ||
| expect_any_instance_of(described_class).to receive(:run).with 'Pending Changes' | ||
| described_class.run 'Pending Changes' | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.