-
Notifications
You must be signed in to change notification settings - Fork 22
Update ember version #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
package.json
Outdated
"lint:js": "eslint .", | ||
"start": "ember serve", | ||
"test": "ember test" | ||
}, | ||
"devDependencies": { | ||
"@ember-decorators/babel-transforms": "^2.0.0", | ||
"@ember/jquery": "^0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this project use jquery? If not let's not make include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove jquery results in
DEPRECATION: The integration of jQuery into Ember has been deprecated and will be removed with Ember 4.0. You can either opt-out of using jQuery, or install the `@ember/jquery` addon to provide the jQuery integration. Please consult the deprecation guide for further details: https://emberjs.com/deprecations/v3.x#toc_jquery-apis
Yes update ember-cli-babel too. I think you can fix it by
notice |
And of course, the project still throws some errors, so you may need to track those down too. Most common fixes include update dependency versions |
Are you talking about the linting errors? |
@abhishek97 I've updated the all the modules now. Now we are not getting the |
@mzfr no we can ignore linting issues for now. But is the project running, do you get any errors in the browser console? |
@abhishek97 Yes, the project seems to be running and No I don't see any error but yes there are few deprecation warnings. |
@abhishek97 What do I need to do in this? |
@abhishek97 Anything else to be done? |
Fixes #17
I have tried to remove the warnings.
The remaining warning is due to
ember-datetime-picker
One of the warnings is
And if we refer to issue ember-cli/ember-cli#7327, it says we need to update the
ember-cli-babel
. So should I update that also?@abhishek97 Please let me know if all the warning/deprecation error has to be removed at all cost