Skip to content

Update ember version #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update ember version #22

wants to merge 5 commits into from

Conversation

mzfr
Copy link

@mzfr mzfr commented May 28, 2019

Fixes #17

I have tried to remove the warnings.
The remaining warning is due to ember-datetime-picker

One of the warnings is

WARNING: You have not included ember-cli-shims in your project's bower.json or package.json. This only works if you provide an alternative yourself and unset app.vendorFiles['app-shims.js'].

And if we refer to issue ember-cli/ember-cli#7327, it says we need to update the ember-cli-babel. So should I update that also?

@abhishek97 Please let me know if all the warning/deprecation error has to be removed at all cost

package.json Outdated
"lint:js": "eslint .",
"start": "ember serve",
"test": "ember test"
},
"devDependencies": {
"@ember-decorators/babel-transforms": "^2.0.0",
"@ember/jquery": "^0.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this project use jquery? If not let's not make include it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove jquery results in

DEPRECATION: The integration of jQuery into Ember has been deprecated and will be removed with Ember 4.0. You can either opt-out of using jQuery, or install the `@ember/jquery` addon to provide the jQuery integration. Please consult the deprecation guide for further details: https://emberjs.com/deprecations/v3.x#toc_jquery-apis

@abhishek97
Copy link
Contributor

Yes update ember-cli-babel too.
Login doesn't work with this. There is an error here: https://github.com/coding-blocks/trouble-maker-frontend/blob/master/app/pods/callback/route.js#L12

I think you can fix it by

return this.get('session').authenticate('authenticator:custom', transition.to.queryParams.code)
      .then(() => this.get('currentUser').load())

notice transition.to.queryParams.codedue to api change.

@abhishek97
Copy link
Contributor

And of course, the project still throws some errors, so you may need to track those down too. Most common fixes include update dependency versions

@mzfr
Copy link
Author

mzfr commented May 28, 2019

Are you talking about the linting errors?

@mzfr
Copy link
Author

mzfr commented May 28, 2019

@abhishek97 I've updated the all the modules now. Now we are not getting the ember-cli-babel deprecated warning.

@abhishek97
Copy link
Contributor

@mzfr no we can ignore linting issues for now. But is the project running, do you get any errors in the browser console?

@mzfr
Copy link
Author

mzfr commented May 28, 2019

@abhishek97 Yes, the project seems to be running and No I don't see any error but yes there are few deprecation warnings.

@mzfr
Copy link
Author

mzfr commented May 29, 2019

@abhishek97 What do I need to do in this?

@mzfr
Copy link
Author

mzfr commented May 31, 2019

@abhishek97 Anything else to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ember version
2 participants