Skip to content

Enable Scrolling to Top #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable Scrolling to Top #420

wants to merge 1 commit into from

Conversation

sourabh1031
Copy link

Fix #418

@abhishek97
Copy link
Contributor

@sourabh1031 This works.
However, we need to preserve scroll position for tabs here
Screenshot 2019-05-27 at 10 53 57 PM

Try scrolling a bit and then switching tabs. We don't want scroll to top here

@sourabh1031 sourabh1031 force-pushed the patch-2 branch 2 times, most recently from f284819 to 825776a Compare May 29, 2019 05:31
@sourabh1031
Copy link
Author

@abhishek97 i have made the required changes.

@abhishek97
Copy link
Contributor

@sourabh1031 This doesn't work. I think you need to specify the preserveScrollPosition qp on overview, announcements ..etc child routes rather than on timeline. Please run project and test before sending PR

@abhishek97 abhishek97 closed this Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We need to scroll to the top of the page, when showing pages
2 participants
@sourabh1031 @abhishek97