Update menu state to auto wrap popover usages with the menu state context provider #1030
+87
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewkfiedler
commented
Mar 19, 2025
andrewkfiedler
commented
- This will automatically handle the majority of use cases, as most times in the application we are directly feeding popover props to a popover. Now those components within will automatically get wrapped with the relevant menu state context.
- For other uses, we provide MenuStateProviderInstance as a convenience for wrapping components with context.
- Updates some of the function calls to utilize useCallback when possible, to minimize rerenders.
- Adds some default implementations for the context functions that will show warnings to devs in the console if they happen to be used in a situation where menu state context is missing.
andrewkfiedler
requested review from
alexabird,
derekwilhelm and
stevenmalmgren
andrewkfiedler
force-pushed
the
UpdateMenuStateContext
branch
from
9cc336a to
b29dd0a
Compare
|
build now |
|
Internal build has been started, your results will be available at build completion. |
andrewkfiedler
commented
Mar 19, 2025
| setOpen(!open) | ||
| } | ||
| const handleClick = React.useCallback(() => { | ||
| setOpen((currentValue) => { |
There was a problem hiding this comment.
Updated this one to a callback and used the ability to access previous value so we could keep the dependency array blank
andrewkfiedler
commented
Mar 19, 2025
| MuiPopoverProps: { | ||
| open, | ||
| onClose: handleClose, | ||
| anchorEl: anchorRef.current, | ||
| action, | ||
| ref: popoverRef.ref, | ||
| ...POPOVER_DEFAULTS({ maxHeight }), | ||
| slotProps: { |
There was a problem hiding this comment.
In most cases we use these popover props, splatting them into the popover, so we'll now automatically get the menu context in those cases.
andrewkfiedler
commented
Mar 19, 2025
| @@ -137,7 +199,10 @@ export function useMenuState({ maxHeight }: Props = {}) { | |||
| ref: anchorRef, | |||
| onClick: handleClick, | |||
| }, | |||
| MenuStateProviderInstance, | |||
There was a problem hiding this comment.
For other use cases not using popovers, we have this as a convenience for wrapping things with the menu context.
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
andrewkfiedler
force-pushed
the
UpdateMenuStateContext
branch
from
b29dd0a to
f5c5bb5
Compare
…text provider - This will automatically handle the majority of use cases, as most times in the application we are directly feeding popover props to a popover. Now those components within will automatically get wrapped with the relevant menu state context. - For other uses, we provide MenuStateProviderInstance as a convenience for wrapping components with context. - Updates some of the function calls to utilize useCallback when possible, to minimize rerenders. - Adds some default implementations for the context functions that will show warnings to devs in the console if they happen to be used in a situation where menu state context is missing. - Adds a convenient method for closing nested menus all at once - Removes unused better click away listener
andrewkfiedler
force-pushed
the
UpdateMenuStateContext
branch
from
f5c5bb5 to
92369f1
Compare
andrewkfiedler
commented
Mar 19, 2025
| @@ -28,7 +28,6 @@ class SubscribableNavigationContextClass extends Subscribable<{ | |||
| ) { | |||
| this.navigationContext = navigationContext | |||
| this._notifySubscribers({ thing: 'update' }) | |||
| console.log('updateNavigationContext', navigationContext) | |||
There was a problem hiding this comment.
Removing some chatty console logs that we don't need.
alexabird
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.