Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate editable attributes / can write permission extensions to overridable pattern #1029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate editable attributes / can write permission extensions to overridable pattern #1029

wants to merge 1 commit into from
+143 −49

Conversation

andrewkfiedler
Copy link
Contributor

  • Migrates these extension points to use overridable instead as it's more flexible, and involves less need to entangle them within startup procedures.
  • Updates the can write usages to use isWritable rather than isNotWritable as that's easier for folks to understand.
  • Fixes an issue with the original editable attributes extension in the new overridable, as previously this could be called many times resulting in a massive amount of network calls, when in reality it needs to only be called once.

@andrewkfiedler
Migrate editable attributes / can write permission extensions to over…
4c8e389 
…ridable pattern

 - Migrates these extension points to use overridable instead as it's more flexible, and involves less need to entangle them within startup procedures.
 - Updates the can write usages to use isWritable rather than isNotWritable as that's easier for folks to understand.
 - Fixes an issue with the original editable attributes extension in the new overridable, as previously this could be called many times resulting in a massive amount of network calls, when in reality it needs to only be called once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexabird alexabird alexabird approved these changes

@stevenmalmgren stevenmalmgren Awaiting requested review from stevenmalmgren

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkfiedler @alexabird