Addressing concerns in #6 #7
Conversation
…r schemas will allow
…jaxb2 maven plugin defaults for file locations
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.jvnet.jaxb2_commons</groupId> | ||
| <artifactId>jaxb2-basics</artifactId> | ||
| <version>${jaxb2.version}</version> |
There was a problem hiding this comment.
✏️ Maybe we could make this a little more distinct from jaxb.version by naming it jvnet.jaxb2.version?
There was a problem hiding this comment.
Good idea, I'm also gonna check to see if there's consistency issues in naming between here and DDF with anything I added in.
|
Yeah, I ran a full build on DDF and it passed. On top of that, I was able to ingest and query over CSW soruces. However, I did have trouble with the geoserver, but haven't verified if it's a preexisting problem on master or something these changes introduced. |
pom.xml
Outdated
| <!-- and cannot be updated until our schemas use a newer version of JAXB2 --> | ||
| <!-- <jaxb2>0.11.0</jaxb2> also uses 2.3.0 --> | ||
| <jaxb.version>2.2.11</jaxb.version> | ||
| <jaxb2.version>0.10.0</jaxb2.version> |
There was a problem hiding this comment.
❓ why did this change from 0.11.1 to 0.10.0 (yeah I know the 1.11.x stuff is wrong).
There was a problem hiding this comment.
Seems like we should use 0.11.1 or even 0.12.0 if possible.
There was a problem hiding this comment.
I don't actually know where 0.11.1 came from to be honest. It doesn't seem like it was being used at all in this repo. ddf-master is still using 0.9.4. @coyotesqrl might know.
There was a problem hiding this comment.
I do not recall where that version came from. I would definitely prefer the latest/greatest if possible.
There was a problem hiding this comment.
I just verified that we can't update with our current schemas. The newer versions of the jaxb2-basics plugin attach what I'll call method 2's to everything. (toString2()). Our schemas call methods that are no longer created with the correct parameters giving us a type mismatch
[ERROR] method ToString.appendFields(ObjectLocator,StringBuilder,ToStringStrategy) is not applicable
[ERROR] (argument mismatch; ToStringStrategy2 cannot be converted to ToStringStrategy)
|
Hero ✔️ |
Requirements
include enough information to be reviewed in a timely manner may be
closed at the maintainers' discretion.
@stustison @coyotesqrl
@bakejeyner @blen-desta
Description of the Change
Cleaning up all the pom.xml files.
Alternate Designs
Two main decisions were made while refactoring. First was to get all the generic configurations used by every child pom into the root pom. The second was to get as much use out of default configurations as possible provided by the
jaxb2-maven-pluginas well as removing unnecessary tags along the way. An example of this is<forceRegenerate>. It has been deprecated as of version0.12.1of the plugin and claimed to be unneeded. However, there's a known issue where if multiple<execution>blocks are run with the same target directory then it will fail to generate any code past the first<execution>block if<forceRegeneration>is not present. The work around for the future to avoid using a deprecated tag is to use separate target directories which has been added in the latest commit.Benefits
Maintainability and consistency.
Possible Drawbacks
None-
Verification Process
Shamelessly copied from here
Applicable Issues
Fixes: #6