Skip to content

Conversation

@rantahar
Copy link
Contributor

@rantahar rantahar commented Sep 2, 2025

Adds a git in VSCode page and refers to that in installation options 2 and 4.

See issue #300

  • This makes the instructions more specific to VSCode. The terminal instructions are more general, but require using the terminal a bit more.
  • Review:
    • Is this the right choice? Should we point everyone to the git-for-terminal page instead and edit it a bit?
    • Does the content flow well? Spelling?

@rantahar rantahar requested review from bast and samumantha September 2, 2025 10:47
@samumantha samumantha requested a review from rkdarst September 2, 2025 12:03
@bast
Copy link
Member

bast commented Sep 2, 2025

  • minor: duplicate label git-configuration
  • the two pages differ in 50% (so i understand that it was a pain to make it generic) but also overlap in 50% (big risk of diverging changes in future) -> i would suggest solving it with one page and tabs so that we only change the common stuff in one place in future
  • but maybe that makes it more confusing for learners and in this case we should abstract the common stuff into a new page instead of repeating

@rantahar
Copy link
Contributor Author

rantahar commented Sep 3, 2025

Tabs are a good idea, why didn't I think of that :)

The biggest differences are between Windows (most setup done while installing) and the rest (config in terminal). Some setup is not needed for VSCode, but it's not that different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants