-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade guardian controller to 1.7 #195
Open
danielsp45
wants to merge
8
commits into
main
Choose a base branch
from
dp/upgrade-guardian-controller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
requested review from
Afonso-santos,
MarioRodrigues10,
nelsonmestevao,
ruilopesm and
ruioliveira02
September 23, 2023 19:55
AI-Generated Summary: This pull request contains a number of changes primarily aimed at refactoring and upgrading the guardian controller from 1.6 to 1.7. It involves modifications in four files with 17 insertions and 18 deletions. The notable changes are following:
|
danielsp45
force-pushed
the
dp/upgrade-guardian-controller
branch
6 times, most recently
from
September 25, 2023 16:56
1c83a4b
to
b31e714
Compare
danielsp45
force-pushed
the
dp/upgrade-guardian-controller
branch
from
September 25, 2023 17:48
b31e714
to
9590a23
Compare
ruilopesm
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
danielsp45
force-pushed
the
dp/upgrade-guardian-controller
branch
from
September 27, 2023 17:58
8f8d4cb
to
d1ae5bc
Compare
ruilopesm
reviewed
Sep 28, 2023
danielsp45
force-pushed
the
dp/upgrade-guardian-controller
branch
from
November 6, 2023 15:18
b80df97
to
b1e5b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.