Skip to content

add via URL fails for large extensions #66

Open

Description

@janLo

Large extensions like sonarlint (300+ MB) cannot be added via URL. I think the relevant part is this: https://github.com/coder/code-marketplace/blob/main/storage/storage.go#L358

I totally understand that there needs to be a limit and I see 100MB also as a good cutoff - but I do think, this should be mentioned in the docs.

Activity

  1. added
    bugSomething isn't working
    documentationImprovements or additions to documentation
    on Oct 25, 2024
  2. code-asher commented on Oct 29, 2024

    @code-asher
    Member

    Agreed, and it seems reasonable to make a flag to change this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions