🤖 feat: add l/h keybinds to mark hunks as read/unread #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2025 17:17
Add vim-style keybindings for marking hunks in code review panel: - l: mark selected hunk as read (reviewed) - h: mark selected hunk as unread (unreviewed) Includes auto-navigation logic to maintain keyboard flow when hunks are filtered out after marking as read (when showReadHunks is false). Follows existing patterns from handleToggleRead for consistent UX. Change-Id: I0f9a9ece1d7678af6e4214e98a71f2f8d0d2073a Signed-off-by: Test <[email protected]>
Change-Id: I4744166633851256bd816785e3c4bdb661b8d7ac Signed-off-by: Test <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vim-style keybindings for marking hunks in the code review panel:
l: mark selected hunk as read (reviewed)h: mark selected hunk as unread (unreviewed)Implementation
The keybindings follow vim conventions where
l(right) moves forward/marks as done, andh(left) moves backward/unmarks.Auto-navigation logic: When
showReadHunksis disabled and a user presseslto mark a hunk as read, the selection automatically advances to the next unread hunk. This maintains keyboard navigation flow and prevents the selection from becoming invalid. The logic reuses the same pattern ashandleToggleReadfor consistency.Testing
Manual testing:
lon unread hunk → marks as read, advances to next unread hunkhon read hunk → marks as unreadshowReadHunksis enabled (no auto-navigation)showReadHunksis disabled (auto-navigation)Generated with
cmux