This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Refined transpose kernel configurations for CPU target & down-sized some copy-op benchmarks #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
requested review from
s-Nick,
muhammad-tanvir-1211 and
pgorlani
s-Nick
approved these changes
Dec 15, 2023
muhammad-tanvir-1211
approved these changes
Dec 19, 2023
muhammad-tanvir-1211
merged commit 39e3747
into
codeplaysoftware:master
3 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the kernel configurations of both
_transpose_outplace&_transpose_addfor default CPU targets resulting in an overall increase in performance (benchmark numbers shared internally).The PR also includes some refactoring of omatcopy/omatadd batched operators benchmarks to address the time consuming ones.