This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Refactor iamax and iamin api to match oneapi spec #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Benchmarks working
…into iamax_iamin_fix
…into iamax_iamin_fix
muhammad-tanvir-1211
requested review from
s-Nick,
pgorlani,
OuadiElfarouki and
aacostadiaz
pgorlani
reviewed
Dec 11, 2023
pgorlani
reviewed
Dec 12, 2023
s-Nick
reviewed
Dec 13, 2023
* Updated the complex header include
s-Nick
reviewed
Dec 15, 2023
pgorlani
approved these changes
Dec 15, 2023
muhammad-tanvir-1211
merged commit 101c87a
into
codeplaysoftware:master
3 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing
iamaxandiaminoperator apis' to match the oneapi specification and introduces abackendspecific single step or two step reduction based on the input size.