Skip to content

Extract clean_top_node from clean_doc. Add unit tests to ensure clean… #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monstrfolk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extract clean_top_node from clean_doc. Add unit tests to ensure clean… #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion newspaper/article.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,13 +270,15 @@ def parse(self):
# Before any computations on the body, clean DOM object
self.doc = document_cleaner.clean(self.doc)

# Extract clean_top_node from clean_doc
self.clean_top_node = self.extractor.calculate_best_node(self.clean_doc)

self.top_node = self.extractor.calculate_best_node(self.doc)
if self.top_node is not None:
video_extractor = VideoExtractor(self.config, self.top_node)
self.set_movies(video_extractor.get_videos())

self.top_node = self.extractor.post_cleanup(self.top_node)
self.clean_top_node = copy.deepcopy(self.top_node)

text, article_html = output_formatter.get_formatted(
self.top_node)
Expand Down
6 changes: 6 additions & 0 deletions tests/unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,12 @@ def test_parse_html(self):
self.assertEqual(META_SITE_NAME, self.article.meta_site_name)
self.assertEqual('2013-11-27 00:00:00', str(self.article.publish_date))

@print_test
def test_clean_top_node_exists_in_clean_doc(self):
self.setup_stage('parse')
self.article.parse()
self.assertTrue(self.article.clean_doc.getroottree().getpath(self.article.clean_top_node))

@print_test
def test_meta_type_extraction(self):
self.setup_stage('meta')
Expand Down