[정지환] sprint 1 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonfluence
reviewed
Jun 10, 2025
Comment on lines
+20
to
+25
| Scanner sc = new Scanner(System.in); | ||
|
|
||
| JCFServiceFactory factory = new JCFServiceFactory(); | ||
| UserService userService = factory.createUserService(); | ||
| MessageService messageService = factory.createMessageService(); | ||
| ChannelService channelService = factory.createChannelService(); |
There was a problem hiding this comment.
Scanner로 분기처리 및 의존성 주입 처리 별도로 팩토리 서비스 만드셔서 처리해준 것 좋습니다
joonfluence
reviewed
Jun 10, 2025
Comment on lines
+37
to
+71
| public List<Channel> getChannels() { | ||
| return channels; | ||
| } | ||
|
|
||
| public List<Message> getMessages() { | ||
| return messages; | ||
| } | ||
|
|
||
| public void updateUserName(String newUserName) { | ||
| this.userName = newUserName; | ||
| } | ||
|
|
||
| public Status getStatus() { return status; } | ||
|
|
||
| public void setStatus(Status status) { this.status = status; } | ||
|
|
||
| public void addChannel(Channel newChannel){ | ||
| if(!channels.contains(newChannel)) { | ||
| channels.add(newChannel); | ||
| newChannel.addUser(this); | ||
| } | ||
| } | ||
|
|
||
| public void removeChannel(Channel newChannel){ | ||
| if(channels.contains(newChannel)) { | ||
| channels.remove(newChannel); | ||
| newChannel.removeUser(this); | ||
| } | ||
| } | ||
|
|
||
| public void addMessage(Message newMessage){ | ||
| this.messages.add(newMessage); | ||
| } | ||
|
|
||
| public void removeMessage(Message m){ this.messages.remove(m); } |
There was a problem hiding this comment.
유저 도메인에 두기에는 너무 과도한 책임이라고 보여집니다 removeMesages, getChannels 등
서비스 계층으로 빼는게 나아보여요
joonfluence
reviewed
Jun 10, 2025
Comment on lines
+25
to
+35
| private JCFChannelService(){ | ||
| data = new ArrayList<>(); | ||
| this.messageService = JCFMessageService.getInstance(); | ||
| } | ||
|
|
||
| public static JCFChannelService getInstance() { | ||
| if (instance == null) { | ||
| instance = new JCFChannelService(); | ||
| } | ||
| return instance; | ||
| } |
joonfluence
reviewed
Jun 10, 2025
|
|
||
| //싱글톤으로 변경 | ||
| private static JCFChannelService instance; | ||
| private final List<Channel> data; |
There was a problem hiding this comment.
리스트로 처리한게 좀 아쉽네요 Map을 쓰는게 더 효과적인 탐색이 가능할텐데요
joonfluence
reviewed
Jun 10, 2025
| public class JCFMessageService implements MessageService { | ||
|
|
||
| private static JCFMessageService instance; | ||
| private final List<Message> data; |
joonfluence
reviewed
Jun 10, 2025
| public class JCFUserService implements UserService { | ||
|
|
||
| private static JCFUserService instance; | ||
| private final List<User> data; |
joonfluence
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
프로젝트 초기화
도메인 모델링
com.sprint.mission.discodeit.entity도메인 모델 정의
id: UUID 타입createdAt,updatedAt: Long 타입생성자
id는 생성자에서 초기화하세요.createdAt은 생성자에서 초기화하세요.메소드
서비스 설계 및 구현
도메인 모델 별 CRUD 인터페이스 선언
com.sprint.mission.discodeit.service[도메인명]Service인터페이스 구현체 작성
com.sprint.mission.discodeit.service.jcfJCF[인터페이스명]data필드를final로 선언하고 생성자에서 초기화메인 클래스 구현 (
JavaApplication)심화 요구 사항
서비스 간 의존성 주입
주요 변경사항
스크린샷
멘토에게