[김민수] Sprint 2 #28
Open
[김민수] Sprint 2 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-kang
reviewed
Jun 18, 2025
Comment on lines
+54
to
+63
| public boolean equals(Object o) { | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| BasedEntity that = (BasedEntity) o; | ||
| return Objects.equals(getId(), that.getId()); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hashCode(getId()); | ||
| } |
There was a problem hiding this comment.
equals랑 hashCode 재정의해서 쓰는 것 굉장히 좋습니다.
spring-kang
reviewed
Jun 18, 2025
Comment on lines
+57
to
+84
| public void addUser(User user) { | ||
| if (this.user == null){ | ||
| this.user = user; | ||
| user.addMessage(this); | ||
| } | ||
| } | ||
|
|
||
| // 작성된 채널 | ||
| public void addChannel(Channel channel) { | ||
| if (this.channel == null){ | ||
| this.channel = channel; | ||
| channel.addMessage(this); | ||
| } | ||
| } | ||
|
|
||
| // 유저가 삭제하거나 유저가 삭제된 경우 | ||
| public void removeUser() { | ||
| if (this.user != null) { | ||
| this.user = null; | ||
| } | ||
| } | ||
|
|
||
| // 채널에서 삭제된 경우 | ||
| public void removeChannel() { | ||
| if (this.channel != null) { | ||
| this.channel = null; | ||
| } | ||
| } |
There was a problem hiding this comment.
여기도 분기 안에서는 예외 처리 밖에서는 비지니스 로직 수행하는 식으로 변경해보세요!
spring-kang
reviewed
Jun 18, 2025
| try (FileInputStream fis = new FileInputStream(FILE_PATH); | ||
| ObjectInputStream ois = new ObjectInputStream(fis)) { | ||
| list = (List<Channel>) ois.readObject(); | ||
| } catch (IOException | ClassNotFoundException e) { |
There was a problem hiding this comment.
에러는 각각 처리해주시는게 더 좋습니다.
spring-kang
reviewed
Jun 18, 2025
| List<Message> list = findAll(); | ||
| if(list.stream().anyMatch(message::equals)){ | ||
| List<Message> updatedList = list.stream().map(c -> c.equals(message) ? message : c) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
불변객체를 리턴하실거라면 아래처럼 수정해주세요. 나머지 코드들도 마찬가지입니다.
Suggested change
| .collect(Collectors.toList()); | |
| .toList(); |
Suggested change
| .collect(Collectors.toList()); | |
| .collect(Collectors.toList()); |
Suggested change
| .collect(Collectors.toList()); | |
| .collect(Collectors.toList()); |
spring-kang
reviewed
Jun 18, 2025
| // 채널 삭제 | ||
| @Override | ||
| public void deleteChannel(Channel channel) { | ||
| validatedChannel(channel); |
There was a problem hiding this comment.
메서드명 수정해주세요.
Suggested change
| validatedChannel(channel); | |
| validateChannel(channel); |
Suggested change
| validatedChannel(channel); | |
| validatedChannel(channel); |
Suggested change
| validatedChannel(channel); | |
| validatedChannel(channel); |
spring-kang
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
File IO를 통한 데이터 영속화
서비스 구현체 분석
레포지토리 설계 및 구현
심화
관심사 분리를 통한 레이어 간 의존성 주입
다음의 조건을 만족하는 서비스 인터페이스의 구현체를 작성하세요.
Basic*Service 구현체를 활용하여 테스트해보세요.
JCF*Repository 구현체를 활용하여 테스트해보세요.
File*Repository 구현체를 활용하여 테스트해보세요.
이전에 작성했던 코드(JCFService 또는 FileService)와 비교해 어떤 차이가 있는지 정리해보세요.
주요 변경사항
멘토에게