-
Notifications
You must be signed in to change notification settings - Fork 16
[강은혁] Sprint8 #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eunhye0k
wants to merge
12
commits into
codeit-bootcamp-spring:강은혁
Choose a base branch
from
Eunhye0k:sprint8
base: 강은혁
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[강은혁] Sprint8 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .gitignore # build.gradle # gradle/wrapper/gradle-wrapper.jar # gradle/wrapper/gradle-wrapper.properties # gradlew # gradlew.bat # settings.gradle # src/main/java/com/sprint/mission/discodeit/entity/Channel.java # src/main/java/com/sprint/mission/discodeit/entity/Message.java # src/main/java/com/sprint/mission/discodeit/entity/User.java # src/main/java/com/sprint/mission/discodeit/repository/ChannelRepository.java # src/main/java/com/sprint/mission/discodeit/repository/MessageRepository.java # src/main/java/com/sprint/mission/discodeit/repository/UserRepository.java # src/main/java/com/sprint/mission/discodeit/service/ChannelService.java # src/main/java/com/sprint/mission/discodeit/service/MessageService.java # src/main/java/com/sprint/mission/discodeit/service/UserService.java
# Conflicts: # build.gradle # src/main/java/com/sprint/mission/discodeit/controller/AuthController.java # src/main/java/com/sprint/mission/discodeit/controller/BinaryContentController.java # src/main/java/com/sprint/mission/discodeit/controller/ChannelController.java # src/main/java/com/sprint/mission/discodeit/controller/MessageController.java # src/main/java/com/sprint/mission/discodeit/controller/ReadStatusController.java # src/main/java/com/sprint/mission/discodeit/controller/UserController.java # src/main/java/com/sprint/mission/discodeit/dto/request/BinaryContentCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/LoginRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/MessageCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/MessageUpdateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/PrivateChannelCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/PublicChannelCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/PublicChannelUpdateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/ReadStatusCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/ReadStatusUpdateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/UserCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/UserStatusCreateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/UserStatusUpdateRequest.java # src/main/java/com/sprint/mission/discodeit/dto/request/UserUpdateRequest.java # src/main/java/com/sprint/mission/discodeit/entity/User.java # src/main/java/com/sprint/mission/discodeit/entity/base/BaseEntity.java # src/main/java/com/sprint/mission/discodeit/exception/DiscodeitException.java # src/main/java/com/sprint/mission/discodeit/exception/ErrorCode.java # src/main/java/com/sprint/mission/discodeit/exception/ErrorResponse.java # src/main/java/com/sprint/mission/discodeit/exception/GlobalExceptionHandler.java # src/main/java/com/sprint/mission/discodeit/exception/channel/ChannelException.java # src/main/java/com/sprint/mission/discodeit/exception/channel/ChannelNotFoundException.java # src/main/java/com/sprint/mission/discodeit/exception/channel/PrivateChannelUpdateException.java # src/main/java/com/sprint/mission/discodeit/exception/message/MessageException.java # src/main/java/com/sprint/mission/discodeit/exception/message/MessageNotFoundException.java # src/main/java/com/sprint/mission/discodeit/exception/user/UserException.java # src/main/java/com/sprint/mission/discodeit/exception/user/UserNotFoundException.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicAuthService.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicBinaryContentService.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicChannelService.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicMessageService.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicReadStatusService.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicUserService.java # src/main/java/com/sprint/mission/discodeit/service/basic/BasicUserStatusService.java # src/main/resources/application-dev.yaml # src/main/resources/application-prod.yaml # src/main/resources/application.yaml # src/main/resources/logback-spring.xml
joonfluence
reviewed
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. 테스트 시, DisplayName을 통해, 좀 더 상세하게 테스트의 동작을 설명해주는 것이 좋습니다!
코드 리베이스 한번 필요할 것 같네요! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
프로젝트 마일스톤
요구사항
기본
애플리케이션 컨테이너화
Dockerfile 작성
이미지 빌드 및 실행 테스트
Docker Compose 구성
BinaryContentStorage 고도화 (AWS S3)
AWS S3 버킷 구성
AWS S3 접근을 위한 IAM 구성
AWS S3 테스트
AWS S3를 활용한 BinaryContentStroage 고도화
discodeit.storage.type 값이 s3인 경우에만 Bean으로 등록되어야 합니다.
S3BinaryContentStorageTest를 함께 작성하면서 구현하세요.
BinaryContentStorage 설정을 유연하게 제어할 수 있도록 application.yaml을 수정하세요.
AWS를 활용한 배포 (AWS RDS, ECR, ECS)
AWS RDS 구성
AWS ECR 구성
이미지를 배포할 퍼블릭 레포지토리(discodeit)를 생성하세요.
AWS CLI를 설치하세요.
aws configure 실행 후 앞서 생성한 discodeit IAM 사용자 정보를 입력하세요.
discodeit IAM 사용자가 ECR에 접근할 수 있도록 다음 권한을 부여하세요.
Docker 클라이언트를 배포할 레지스트리에 대해 인증합니다.
멀티플랫폼을 지원하도록 애플리케이션 이미지를 빌드하고, discodeit 레포지토리에 push 하세요.
태그명: latest, 1.2-M8
멀티플랫폼: linux/amd64,linux/arm64
AWS 콘솔에서 푸시된 이미지를 확인하세요.
AWS ECS 구성
이 파일을 S3에 업로드하세요.
이 파일은 형상관리되지 않도록 주의하세요.
AWS ECS 콘솔에서 클러스터를 생성하세요.
이외 설정은 기본값을 유지하세요.
심화
이미지 최적화하기
멀티 스테이지(빌드, 런타임) 빌드를 활용해 이미지의 크기를 줄여보세요.
이미지 레이어 캐시를 고려해 Dockerfile을 수정해보세요.
GitHub Actions를 활용한 CI/CD 파이프라인 구축
CI(지속적 통합)를 위한 워크플로우를 설정하세요.
.github/workflows/test.yml 파일을 생성하세요.
main 브랜치에 PR이 생성되면 실행되도록 설정하세요.
테스트가 실행하는 Job을 정의하세요.
CodeCov를 통해 테스트 커버리지 뱃지를 README에 추가해보세요.
CD(지속적 배포)를 위한 워크플로우를 설정하세요.
ECS 서비스 업데이트
ECS 서비스를 업데이트하는 Job을 정의하세요.
AWS CLI를 설정하는 Step을 추가하세요.
태스크 정의를 업데이트하는 Step을 추가하세요.
프리티어 리소스를 고려해 AWS CLI를 사용해 기존에 구동 중인 서비스를 중단하는 Step을 추가하세요.
새로 등록한 태스크 정의를 사용하도록 ECS 서비스를 업데이트하는 Step을 추가하세요.
리뷰를 위해 PR에 포함해야할 정보
멘토에게