Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Aug 9, 2025

This PR contains the following updates:

Package Type Update Change
pre-commit/pre-commit-hooks repository major v5.0.0 -> v6.0.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Note: The pre-commit manager in Renovate is not supported by the pre-commit maintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.


Release Notes

pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)

v6.0.0: pre-commit-hooks v6.0.0

Compare Source

Fixes

Migrating


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@codegen-sh
Copy link

codegen-sh bot commented Aug 9, 2025

High-level review

This PR upgrades pre-commit/pre-commit-hooks from v5.0.0 to v6.0.0 in .pre-commit-config.yaml. The change is minimal and the config does not use any hooks that were removed or changed incompatibly in v6.

Code quality and best practices

  • Compatibility: v6 requires Python >= 3.9. The repo’s Python bindings already require >=3.11 (bindings/python/pyproject.toml), and GitHub runners ship with >=3.10, so CI should be fine. One small safeguard: ensure the pre-commit workflow runs with a Python >=3.9 interpreter (see below) to avoid issues for forks/self-hosted runners.
  • Removed hooks in v6: check-byte-order-marker, fix-encoding-pragma. Your config does not reference these, so no action needed.
  • Behavior change: file-contents-sorter disallows --unique and --ignore-case together in v6. You’re not using this hook, so no impact.

Architecture and organization

  • No architectural impact; this is a straightforward dependency bump in tooling.

CI considerations

  • The pre-commit workflow (.github/workflows/pre-commit.yml) uses a custom ./.github/actions/setup-environment. If that action does not explicitly install/configure Python, consider adding an actions/setup-python@v5 step (e.g., python-version: '3.11') before running pre-commit/action to guarantee Python >=3.9 is available for hook environments on all runners, including self-hosted or older images.
  • pre-commit/[email protected] is compatible; no change required.

Testing

  • Recommend running pre-commit locally (pre-commit run -a) and verifying the workflow passes on this branch. Given the minimal diff, failures are unlikely.

Documentation

  • If any contributors are still on Python 3.8, the new hook set will fail to create environments. Consider a quick note in CONTRIBUTING.md (if present/added later) that pre-commit now requires Python >=3.9.

Conclusion

  • LGTM as-is. The upgrade is safe for this repo based on the current configuration. My only actionable suggestion is to ensure the CI environment for the pre-commit job explicitly provides Python >=3.9 to avoid surprises on non-standard runners.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 9, 2025

CodSpeed Performance Report

Merging #116 will not alter performance

Comparing renovate/pre-commit-pre-commit-hooks-6.x (c98fc9e) with main (357f1ea)

Summary

✅ 5 untouched

@renovate renovate bot force-pushed the renovate/pre-commit-pre-commit-hooks-6.x branch from b55e162 to c98fc9e Compare September 25, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant