Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: JOBD viewer #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat: JOBD viewer #12

wants to merge 4 commits into from

Conversation

sebCIL
Copy link

@sebCIL sebCIL commented Jan 19, 2023 •
edited
Loading

Changes

Add JOBD viewer

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • for feature PRs: PR only includes one feature enhancement.

sebjulliand
sebjulliand requested changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very nice change!
I'd just advise the webview toolkit to be used to ensure UI consistency across all webviews 😉

src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
@sebCIL
Copy link
Author

sebCIL commented Feb 5, 2023

Done !
Thx for your help. I'll look at my others commit.

sebjulliand
sebjulliand requested changes Feb 14, 2023
View reviewed changes
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
src/types/jobDescription.ts Outdated Show resolved Hide resolved
@sebjulliand
Copy link
Collaborator

Done ! Thx for your help. I'll look at my others commit.

Thanks for your hard work Seb!
There are just a few remaining changes you may want to look at and we'll be good to go!

@sebCIL sebCIL requested a review from sebjulliand February 21, 2023 11:33
@sebCIL sebCIL changed the title Add JOBD viewer Feat: JOBD viewer Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand Awaiting requested review from sebjulliand

Assignees
No one assigned
Labels
None yet
Projects
vscode-ibmi-fs plans
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebCIL @sebjulliand