Skip to content

Update standard #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update standard #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a786d95
update standard gem
mrotondo Sep 10, 2025
3b222af
standard fixes
mrotondo Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ GEM
racc (~> 1.4)
orm_adapter (0.5.0)
parallel (1.27.0)
parser (3.3.8.0)
parser (3.3.9.0)
ast (~> 2.4.1)
racc
pg (1.6.1)
Expand Down Expand Up @@ -381,7 +381,7 @@ GEM
rdoc (6.14.2)
erb
psych (>= 4.0.0)
regexp_parser (2.10.0)
regexp_parser (2.11.2)
reline (0.6.2)
io-console (~> 0.5)
responders (3.1.1)
Expand All @@ -405,15 +405,15 @@ GEM
rspec-mocks (~> 3.13)
rspec-support (~> 3.13)
rspec-support (3.13.4)
rubocop (1.75.8)
rubocop (1.80.2)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.44.0, < 2.0)
rubocop-ast (>= 1.46.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.46.0)
Expand Down Expand Up @@ -480,10 +480,10 @@ GEM
activejob (>= 7.2)
activerecord (>= 7.2)
railties (>= 7.2)
standard (1.50.0)
standard (1.51.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.75.5)
rubocop (~> 1.80.2)
standard-custom (~> 1.0.0)
standard-performance (~> 1.8)
standard-custom (1.0.2)
Expand Down Expand Up @@ -512,9 +512,9 @@ GEM
nokogiri (>= 1.6, < 2.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.1.4)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
unicode-display_width (3.2.0)
unicode-emoji (~> 4.1)
unicode-emoji (4.1.0)
uri (1.0.3)
useragent (0.16.11)
valid_email2 (7.0.13)
Expand Down
2 changes: 2 additions & 0 deletions app/forms/form_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module FormAttributes

included do
extend AutoStripAttributes

class_attribute :attribute_names

def initialize(*args, **kwargs)
Expand All @@ -12,6 +13,7 @@ def initialize(*args, **kwargs)

self.class.scoped_attributes.values.flatten.each do |attribute_string|
next unless send(attribute_string).blank?

send("#{attribute_string}=", default_attrs&.fetch(attribute_string, nil))
end
end
Expand Down
2 changes: 1 addition & 1 deletion app/helpers/vita_min_form_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def vita_min_checkbox_set(
end.join).html_safe

checkbox_container_classes = ["tight-ish-checkboxes"]
includes_follow_up = (collection.any? { |item| item[:opens_follow_up_with_id] }) || (checkbox_html.include? "follow-up")
includes_follow_up = collection.any? { |item| item[:opens_follow_up_with_id] } || (checkbox_html.include? "follow-up")
checkbox_container_classes << "question-with-follow-up" if includes_follow_up

fieldset_classes = ["input-group", "form-group#{error_state(object, method)}"]
Expand Down
Loading