Go to Overview even for resuming #2815

Arpan-206 · 2025-04-29T17:00:10Z

Checklist:

I've thoroughly self-reviewed my changes
I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

Summary by CodeRabbit

Bug Fixes
- Updated course card navigation to always direct users to the course overview page, regardless of previous activity.
Tests
- Enhanced acceptance tests to explicitly verify navigation to the course overview page before starting a course, ensuring accurate user flow validation.

linear · 2025-04-29T17:00:14Z

CC-1714 Don't bypass the overview page

coderabbitai · 2025-04-29T17:00:18Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the navigation behavior when selecting a course card by consistently directing users to the course overview page, regardless of repository state. The logic in the course card component was simplified to always generate the same route. Correspondingly, acceptance tests were updated to assert that navigation to the overview page occurs before any subsequent actions, ensuring the application's flow is predictable and verified at each step.

Changes

File(s)	Change Summary
app/components/course-card/index.js	Simplified the `linkToRoute` getter to always return the course overview route, removing conditional logic.
tests/acceptance/course-page/start-course-test.js tests/acceptance/course-page/view-course-stages-test.js	Updated tests to assert navigation to the course overview page after selecting a course from the catalog.

Poem

🐇
Hop, hop, to the overview we go,
No more forks in the route to sow.
The tests now check each little leap,
Ensuring our courses never lose sleep.
With every click, the path is clear—
Straight to the overview, year after year!
🌱

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-04-29T17:00:40Z

Bundle Report

Changes will decrease total bundle size by 86 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
client-array-push	36.58MB	-86 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/chunk.*.js`	-86 bytes	2.84MB	-0.0%

github-actions · 2025-04-29T17:02:44Z

Test Results

1 files ± 0 1 suites ±0 8m 0s ⏱️ - 1m 23s
614 tests - 10 551 ✅ - 24 45 💤 ±0 0 ❌ ± 0 18 🔥 +14
614 runs - 10 533 ✅ - 38 45 💤 ±0 18 ❌ +14 18 🔥 +14

For more details on these errors, see this check.

Results for commit b7be805. ± Comparison against base commit 8f14f91.

This pull request removes 11 and adds 1 tests. Note that renamed tests count towards both.

Chrome 135.0 ‑ Acceptance | view-course-overview: it has a longer notice for paid users when a course is deprecated
Chrome 135.0 ‑ Acceptance | view-course-overview: it has the notice for when a course is deprecated
Chrome 135.0 ‑ Acceptance | view-course-overview: it has the notice for when a course is free
Chrome 135.0 ‑ Acceptance | view-course-overview: it has the notice for when a course is in beta status
Chrome 135.0 ‑ Acceptance | view-course-overview: it renders for course with extensions
Chrome 135.0 ‑ Acceptance | view-course-overview: it renders for course without extensions
Chrome 135.0 ‑ Acceptance | view-course-overview: it renders when anonymous user views alpha course
Chrome 135.0 ‑ Acceptance | view-course-overview: it renders when user accesses URL directly
Chrome 135.0 ‑ Acceptance | view-course-overview: it renders when user is logged in
Chrome 135.0 ‑ Acceptance | view-course-overview: it renders when user is not logged in
…

Chrome ‑ error

♻️ This comment has been updated with latest results.

codecov · 2025-04-29T17:02:46Z

❌ 18 Tests Failed:

Tests completed	Failed	Passed	Skipped
569	18	551	45

View the top 3 failed test(s) by shortest run time

Chrome error

Stack Traces | 0s run time

Error: Browser timeout exceeded: 10s
Error while executing test: Acceptance | view-course-overview: it renders when user is not logged in
Stderr: 
 [2981:3339:0501/102036.319089:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:3339:0501/102036.351970:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:3339:0501/102036.352860:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:3339:0501/102036.352869:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
Fontconfig error: No writable cache directories
[2981:3339:0501/102044.061259:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:3339:0501/102044.493754:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:3339:0501/102045.103133:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")

DevTools listening on ws://127.0.0.1:.../devtools/browser/edd34284-d76f-462d-a9f7-2110e87c904a
[2981:2981:0501/102046.629767:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[2981:2981:0501/102046.742186:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[2981:3339:0501/102046.742292:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:3339:0501/102046.742302:ERROR:bus.cc(408)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[2981:2981:0501/102046.743718:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[2981:2981:0501/102046.789598:ERROR:global_accelerator_listener_linux.cc(350)] Failed to connect to signal: org.freedesktop.portal.GlobalShortcuts.Activated
[2981:4558:0501/102046.804128:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= ........./org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[2981:4558:0501/102046.804289:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= ........./org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[2981:4558:0501/102046.804370:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= ........./org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[2981:2981:0501/102046.805489:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[2981:2981:0501/102046.806031:ERROR:object_proxy.cc(589)] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= .............../org/freedesktop/DBus: unknown error type: 
[4326:4695:0501/102048.177812:ERROR:command_buffer_proxy_impl.cc(127)] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer.
Created TensorFlow Lite XNNPACK delegate for CPU.
Attempting to use a delegate that only supports static-sized tensors with a graph that has dynamic-sized tensors (tensor#-1 is a dynamic-sized tensor).

Chrome 135.0 Acceptance | course-page | dark-mode: free users can view upgrade prompt

Stack Traces | 0.433s run time

Promise rejected during "free users can view upgrade prompt": Element not found.

PageObject: 'page'
  Selector: '[data-test-course-overview-header] [data-test-start-course-button]'

PageObject: 'page.clickOnStartCourse()'
  Selector: '[data-test-course-overview-header] [data-test-start-course-button]'

Chrome 135.0 Acceptance | course-page | start-course: can start repo and abandon halfway (regression)

Stack Traces | 0.447s run time

Promise rejected during "can start repo and abandon halfway (regression)": Element not found.

PageObject: 'page'
  Selector: '[data-test-course-overview-header] [data-test-start-course-button]'

PageObject: 'page.clickOnStartCourse()'
  Selector: '[data-test-course-overview-header] [data-test-start-course-button]'

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

rohitpaulk · 2025-04-29T18:09:04Z

@Arpan-206 change looks good but you have a ton of failing tests

rohitpaulk

Failing tests

Go to Overview even for resuming

51ebd54

vercel bot deployed to Preview – frontend April 29, 2025 17:00 View deployment

Arpan-206 requested a review from rohitpaulk April 29, 2025 17:00

vercel bot deployed to Preview – frontend-stg April 29, 2025 17:00 View deployment

Arpan-206 marked this pull request as draft April 29, 2025 17:03

rohitpaulk requested changes Apr 29, 2025

View reviewed changes

Arpan-206 added 2 commits May 1, 2025 10:40

most tests are passing

b1cf152

fix more tests

ffb72a8

vercel bot deployed to Preview – frontend May 1, 2025 10:18 View deployment

vercel bot deployed to Preview – frontend-stg May 1, 2025 10:18 View deployment

linter fix

b7be805

vercel bot deployed to Preview – frontend May 1, 2025 10:22 View deployment

vercel bot deployed to Preview – frontend-stg May 1, 2025 10:23 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go to Overview even for resuming #2815

Go to Overview even for resuming #2815

Arpan-206 commented Apr 29, 2025 •

edited by coderabbitai bot

Loading

linear bot commented Apr 29, 2025

coderabbitai bot commented Apr 29, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Apr 29, 2025 •

edited

Loading

Assets Changed:

github-actions bot commented Apr 29, 2025 •

edited

Loading

codecov bot commented Apr 29, 2025 •

edited

Loading

rohitpaulk commented Apr 29, 2025

rohitpaulk left a comment

Go to Overview even for resuming #2815

Are you sure you want to change the base?

Go to Overview even for resuming #2815

Conversation

Arpan-206 commented Apr 29, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

linear bot commented Apr 29, 2025

coderabbitai bot commented Apr 29, 2025 • edited Loading

Review skipped

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Apr 29, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

github-actions bot commented Apr 29, 2025 • edited Loading

Test Results

codecov bot commented Apr 29, 2025 • edited Loading

❌ 18 Tests Failed:

rohitpaulk commented Apr 29, 2025

rohitpaulk left a comment

Choose a reason for hiding this comment

Arpan-206 commented Apr 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Apr 29, 2025 •

edited

Loading

github-actions bot commented Apr 29, 2025 •

edited

Loading

codecov bot commented Apr 29, 2025 •

edited

Loading