Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 57 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 57 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented Aug 30, 2023

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @Kamaqen

github-classroom bot and others added 30 commits August 30, 2023 19:56
ADD: missing images to home page
ADD: form section for creating tasks to home page
FIX: add task listener to refresh tasks
“Kamaqen” and others added 27 commits September 1, 2023 19:53
ADD: input checkbox customization
UPDATE: background color for header
ADD: sort tasks html structure
FIX: tasks sort method to only refresh list
ADD: task filtering html structure
UPDATE: css in the filter section
FIX: submit button not working
ADD: listener to the task list checkboxes
ADD: listeners to toggle important value in tasks
ADD: listener to filter tasks by completed state
ADD: listeners to show only important tasks
@andresnb
Copy link

andresnb commented Sep 5, 2023

JavaScript - Week 4 - Individual - Doable

This rubic breaks the project into several key objectives.
Each one of the goals is scored with the scales listed in the table below.

SKILL 0 1 2 3 4 5
Dev Skills Not applied Barely applied Somewhat applied Decently applied Mostly applied Correctly applied
User Stories Not applied Applied but with glitches Correctly applied
Critical User Stories Not applied Applied but not working Applied but with glitches Correctly applied
Non Critical Features Not applied Applied

To pass, the student needs at least 35
(total of 50 points + 5 bonus points)

STUDENT: JORGE MARTIN CAPCHA LLANOS
RESULT: APROVED

Total 46
Dev skills 17
User stories 29
Bonus stories 0

DETAILS

Dev Skills Max Score Your Score
Deliver in time (September 2) 5 4
The code, html and assets are properly divided in files according to their purpose. No trash files 5 5
Work properly with multiple branches, each branch should be a unique featuren (will not be quantified until next individual) 5 3
Commits are well-written and communicates clearly what the coder did 5 5
TOTAL 20 17
User stories Max Score Your Score
User can create an account 3 3
User can login 3 3
User can logout 2 2
User can create a task 3 3
Use can mark a task as completed 3 3
User can mark a task as important 3 3
User can filter by pending tasks only 2 2
User can filter by important tasks only 2 2
User can sort tasks alphabetically 2 2
User can sort tasks by due date -recents first- 2 2
User can sort tasks by importance -importants first- 2 2
CSS styling are pixel perfect 3 2
TOTAL 30 29
Bonus stories Max Score Your Score
Tests (crear una tarea, tarea completada, ordenar las tareas alfabéticamente) 3 0
Readme 2 0
TOTAL 5 0

NOTES

  • recuerda crear mas ramas dependiendo del feature del programa
  • El css esta un poco descuadrado, utilizar flex o grid de manera mas eficiente
  • recuerda tener los contenedores bien deifinidos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants