docs(git-master): make language handling generic (incl. Japanese examples)#3096
Open
s2mr wants to merge 3 commits intocode-yeongyu:devfrom
Open
docs(git-master): make language handling generic (incl. Japanese examples)#3096s2mr wants to merge 3 commits intocode-yeongyu:devfrom
s2mr wants to merge 3 commits intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 3/5
- There is some regression risk:
src/features/builtin-skills/skills/git-master-sections/commit-workflow.tsappears mid-migration, where new multilingual/profile instructions conflict with legacy single-language validation logic. - Because this is a concrete behavior mismatch (severity 6/10 with high confidence 9/10), users may hit incorrect validation outcomes until both paths are aligned.
- Pay close attention to
src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts- resolve validation/instruction consistency during the language-profile migration.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts">
<violation number="1" location="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts:96">
P2: Language-profile migration is incomplete: new multilingual/profile instructions conflict with remaining single-language validation checks.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -35,18 +35,18 @@ git log --oneline $(git merge-base HEAD main 2>/dev/null || git merge-base HEAD | |||
| <style_detection> | |||
There was a problem hiding this comment.
P2: Language-profile migration is incomplete: new multilingual/profile instructions conflict with remaining single-language validation checks.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts, line 96:
<comment>Language-profile migration is incomplete: new multilingual/profile instructions conflict with remaining single-language validation checks.</comment>
<file context>
@@ -93,7 +93,7 @@ Reference examples from repo:
3. "actual commit message from log"
-All commits will follow: [LANGUAGE] + [STYLE]
+All commits will follow: [DOMINANT_LANGUAGE_OR_SCRIPT] + [STYLE]
\`\`\`
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
git-masterskill had English/Korean-centric wording throughout its language detection and commit message guidance, making it unclear whether other languages (e.g., Japanese) are supported. This PR makes all language-related guidance fully language-agnostic.Fixes #3097
Changes
xxxを追加) alongside Korean (xxx 추가)src/features/builtin-skills/git-master/SKILL.mdto match all section-template changesTesting
bun test src/features/opencode-skill-loader/git-master-template-injection.test.ts— 10 pass ✅bun run typecheck✅bun run build✅