Skip to content

docs(git-master): make language handling generic (incl. Japanese examples)#3096

Open
s2mr wants to merge 4 commits intocode-yeongyu:devfrom
s2mr:fix/git-master-language-agnostic-support
Open

docs(git-master): make language handling generic (incl. Japanese examples)#3096
s2mr wants to merge 4 commits intocode-yeongyu:devfrom
s2mr:fix/git-master-language-agnostic-support

Conversation

@s2mr
Copy link
Copy Markdown

@s2mr s2mr commented Apr 3, 2026

Summary

The git-master skill had English/Korean-centric wording throughout its language detection and commit message guidance, making it unclear whether other languages (e.g., Japanese) are supported. This PR makes all language-related guidance fully language-agnostic.

Fixes #3097

Changes

  • Mode detection triggers: replaced hardcoded Korean examples with generic "any language" phrasing, adding Japanese examples alongside existing ones
  • Language profile detection (Phase 1.1): removed binary Korean/English detection logic; replaced with language-agnostic "dominant language pattern" approach that works for any repository language
  • Commit message generation (Phase 5.4): removed KOREAN/ENGLISH branching; now shows multilingual examples (English, Japanese, Korean) as illustrative only
  • History search triggers: added Japanese example phrases alongside Korean ones
  • Rebase mode triggers: added Japanese example phrases alongside Korean ones
  • Quick reference cheat sheet: added Japanese example (xxxを追加) alongside Korean (xxx 추가)
  • Synced src/features/builtin-skills/git-master/SKILL.md to match all section-template changes

Testing

  • bun test src/features/opencode-skill-loader/git-master-template-injection.test.ts — 10 pass ✅
  • bun run typecheck
  • bun run build

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

@s2mr
Copy link
Copy Markdown
Author

s2mr commented Apr 3, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 3, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Confidence score: 3/5

  • There is some regression risk: src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts appears mid-migration, where new multilingual/profile instructions conflict with legacy single-language validation logic.
  • Because this is a concrete behavior mismatch (severity 6/10 with high confidence 9/10), users may hit incorrect validation outcomes until both paths are aligned.
  • Pay close attention to src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts - resolve validation/instruction consistency during the language-profile migration.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts">

<violation number="1" location="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts:96">
P2: Language-profile migration is incomplete: new multilingual/profile instructions conflict with remaining single-language validation checks.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts">

<violation number="1" location="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts:458">
P2: This validation now contradicts Phase 1.1 by rejecting valid module-specific secondary-language commit messages in multilingual repos.</violation>
</file>

<file name="src/features/builtin-skills/git-master/SKILL.md">

<violation number="1" location="src/features/builtin-skills/git-master/SKILL.md:530">
P2: New dominant-language validation conflicts with the file’s own multilingual/module-local fallback rule, causing valid module-local messages to be rewritten incorrectly.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

**VALIDATION before each commit:**
1. Does message match detected style?
2. Does language match detected language?
2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This validation now contradicts Phase 1.1 by rejecting valid module-specific secondary-language commit messages in multilingual repos.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts, line 458:

<comment>This validation now contradicts Phase 1.1 by rejecting valid module-specific secondary-language commit messages in multilingual repos.</comment>

<file context>
@@ -455,7 +455,7 @@ IF style == SHORT:
 **VALIDATION before each commit:**
 1. Does message match detected style?
-2. Does language match detected language?
+2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
 3. Is it similar to examples from git log?
 
</file context>
Suggested change
2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
2. Does message follow Phase 1.1's language/script guidance (dominant profile, or nearest recent module examples when multiple languages are common)?
Fix with Cubic

**VALIDATION before each commit:**
1. Does message match detected style?
2. Does language match detected language?
2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: New dominant-language validation conflicts with the file’s own multilingual/module-local fallback rule, causing valid module-local messages to be rewritten incorrectly.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/features/builtin-skills/git-master/SKILL.md, line 530:

<comment>New dominant-language validation conflicts with the file’s own multilingual/module-local fallback rule, causing valid module-local messages to be rewritten incorrectly.</comment>

<file context>
@@ -527,7 +527,7 @@ IF style == SHORT:
 **VALIDATION before each commit:**
 1. Does message match detected style?
-2. Does language match detected language?
+2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
 3. Is it similar to examples from git log?
 
</file context>
Suggested change
2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
2. Does message follow the language/script decision from Phase 1.1 (dominant profile, or module-local pattern when multiple languages are common)?
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-master skill: language detection assumes only English/Korean

1 participant