docs(git-master): make language handling generic (incl. Japanese examples)#3096
docs(git-master): make language handling generic (incl. Japanese examples)#3096s2mr wants to merge 4 commits intocode-yeongyu:devfrom
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 3/5
- There is some regression risk:
src/features/builtin-skills/skills/git-master-sections/commit-workflow.tsappears mid-migration, where new multilingual/profile instructions conflict with legacy single-language validation logic. - Because this is a concrete behavior mismatch (severity 6/10 with high confidence 9/10), users may hit incorrect validation outcomes until both paths are aligned.
- Pay close attention to
src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts- resolve validation/instruction consistency during the language-profile migration.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts">
<violation number="1" location="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts:96">
P2: Language-profile migration is incomplete: new multilingual/profile instructions conflict with remaining single-language validation checks.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts">
<violation number="1" location="src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts:458">
P2: This validation now contradicts Phase 1.1 by rejecting valid module-specific secondary-language commit messages in multilingual repos.</violation>
</file>
<file name="src/features/builtin-skills/git-master/SKILL.md">
<violation number="1" location="src/features/builtin-skills/git-master/SKILL.md:530">
P2: New dominant-language validation conflicts with the file’s own multilingual/module-local fallback rule, causing valid module-local messages to be rewritten incorrectly.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| **VALIDATION before each commit:** | ||
| 1. Does message match detected style? | ||
| 2. Does language match detected language? | ||
| 2. Does message use the repository's dominant language/script profile (from Phase 1.1)? |
There was a problem hiding this comment.
P2: This validation now contradicts Phase 1.1 by rejecting valid module-specific secondary-language commit messages in multilingual repos.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/features/builtin-skills/skills/git-master-sections/commit-workflow.ts, line 458:
<comment>This validation now contradicts Phase 1.1 by rejecting valid module-specific secondary-language commit messages in multilingual repos.</comment>
<file context>
@@ -455,7 +455,7 @@ IF style == SHORT:
**VALIDATION before each commit:**
1. Does message match detected style?
-2. Does language match detected language?
+2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
3. Is it similar to examples from git log?
</file context>
| 2. Does message use the repository's dominant language/script profile (from Phase 1.1)? | |
| 2. Does message follow Phase 1.1's language/script guidance (dominant profile, or nearest recent module examples when multiple languages are common)? |
| **VALIDATION before each commit:** | ||
| 1. Does message match detected style? | ||
| 2. Does language match detected language? | ||
| 2. Does message use the repository's dominant language/script profile (from Phase 1.1)? |
There was a problem hiding this comment.
P2: New dominant-language validation conflicts with the file’s own multilingual/module-local fallback rule, causing valid module-local messages to be rewritten incorrectly.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/features/builtin-skills/git-master/SKILL.md, line 530:
<comment>New dominant-language validation conflicts with the file’s own multilingual/module-local fallback rule, causing valid module-local messages to be rewritten incorrectly.</comment>
<file context>
@@ -527,7 +527,7 @@ IF style == SHORT:
**VALIDATION before each commit:**
1. Does message match detected style?
-2. Does language match detected language?
+2. Does message use the repository's dominant language/script profile (from Phase 1.1)?
3. Is it similar to examples from git log?
</file context>
| 2. Does message use the repository's dominant language/script profile (from Phase 1.1)? | |
| 2. Does message follow the language/script decision from Phase 1.1 (dominant profile, or module-local pattern when multiple languages are common)? |
Summary
The
git-masterskill had English/Korean-centric wording throughout its language detection and commit message guidance, making it unclear whether other languages (e.g., Japanese) are supported. This PR makes all language-related guidance fully language-agnostic.Fixes #3097
Changes
xxxを追加) alongside Korean (xxx 추가)src/features/builtin-skills/git-master/SKILL.mdto match all section-template changesTesting
bun test src/features/opencode-skill-loader/git-master-template-injection.test.ts— 10 pass ✅bun run typecheck✅bun run build✅