Skip to content

build: fix nx release packageRoot after build outputs moved #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025

Conversation

matejchalk
Copy link
Collaborator

Required change after #1052, needed for nx release to work properly. Also explicitly excluded dist from cache inputs, just in case it interferes.

Copy link

pkg-pr-new bot commented Aug 13, 2025

Open in StackBlitz

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1063

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1063

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1063

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1063

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1063

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1063

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1063

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1063

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1063

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1063

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1063

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1063

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1063

commit: 9a2d2de

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bee7cce with previous commit 0aee085.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 31 🔴 31 ↓ −0.6
Code coverage 🟢 90 🟢 90 ↓ −0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 2 groups regressed, 👍 2 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 31 🔴 31 ↓ −0.6
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 830 ms 🟩 Root document took 530 ms ↓ −36.6 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.3 s ↑ +8.5 %
Lighthouse Speed Index 🟥 8.9 s 🟥 8.6 s ↓ −3.6 %
Code coverage Branch coverage 🟨 85 % 🟨 85 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,661 KiB 🟩 Total size was 2,664 KiB ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 20.4 s 🟥 21.2 s ↑ +4.1 %
Lighthouse Total Blocking Time 🟥 6,330 ms 🟥 7,030 ms ↑ +11 %
Lighthouse Server Backend Latencies 🟩 1,810 ms 🟩 1,150 ms ↓ −36.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.9 %
Lighthouse Time to Interactive 🟥 18.7 s 🟥 19.1 s ↑ +1.9 %
Lighthouse Largest Contentful Paint 🟥 12.5 s 🟥 12.2 s ↓ −1.9 %
Lighthouse Max Potential First Input Delay 🟥 2,000 ms 🟥 2,230 ms ↑ +11.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 102 KiB 🟥 Potential savings of 102 KiB ↓ −21.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 9.7 s 🟥 9.8 s ↑ +1.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 549 KiB 🟥 Potential savings of 549 KiB ↑ +5.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 30 ms ↑ +154.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 102 KiB 🟥 Potential savings of 103 KiB ↑ +3.2 %

592 other audits are unchanged.

@matejchalk matejchalk merged commit bce59c0 into main Aug 13, 2025
18 checks passed
@matejchalk matejchalk deleted the release-config-fix branch August 13, 2025 11:44
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants