Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 12, 2025

Followup of:

Precondition:

This PR includes:

  • add helper to load envVars
  • adjusted nx.json
    • add defaultTargets for main and plugin code-pushup targets
    • add default inputs
  • add plugin caching to code-pushup target
  • cache js-packages and invalidate daily
  • GH adjustments
    • added affected and --parallel=3
  • Adjust path helper that that created Nx project graph to use readCachedProjectGraph to avoid problems when running plugins in parallel

Note

I cache the js-packges plugin target, against our discussion, as only in this PR I would have saved ~4min

Followup Todos:

  • move zod2md.ts under tools and leverage "!{projectRoot}/tools/**/*" in nx.json#namedInputs.production
  • rename nx-plugin/mock to models/mocks and adjust inputs
  • cleanup e2e targets leverage nx.json#targetDefaults
  • include only relevant projects in plugin-eslint config
  • stricter task dependencies to avoid running tracked libs e.g. nx run test-nx-utils:unit-test is executed ATM
  • understand why e2e tests fail if nx.json#defaultTargets[N].@nx/vite:test as empty ({}) target is removed

Followup PRs:

Copy link

pkg-pr-new bot commented Aug 12, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1062

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1062

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1062

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1062

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1062

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1062

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1062

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1062

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1062

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1062

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1062

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1062

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1062

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1062

commit: 566c6da

Copy link

github-actions bot commented Aug 12, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 276ddd6 with previous commit b08a9a7.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 31 🔴 30 ↓ −1
Code coverage 🟢 91 🟢 90 ↓ −0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 4 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 31 🔴 30 ↓ −1
Code coverage Code coverage metrics 🟢 91 🟢 90 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.7 s ↑ +16.1 %
Lighthouse Speed Index 🟥 8.3 s 🟥 7.8 s ↓ −5.8 %
Lighthouse Time to Interactive 🟥 19.7 s 🟥 17.7 s ↓ −10.2 %
Code coverage Line coverage 🟨 87.6 % 🟨 87.1 % ↓ −0.6 %
JSDoc coverage Functions coverage 🟥 517 undocumented functions 🟥 517 undocumented functions  +0 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86.2 % ↓ −0.1 %
Code coverage Function coverage 🟩 93.2 % 🟩 93.1 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 21.6 s 🟥 16.4 s ↓ −23.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,652 KiB 🟩 Total size was 2,648 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 10.6 s 🟥 6.7 s ↓ −37 %
Lighthouse Total Blocking Time 🟥 7,860 ms 🟥 5,210 ms ↓ −33.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −10.2 %
Lighthouse Largest Contentful Paint 🟥 13.2 s 🟥 12.0 s ↓ −9.3 %
Lighthouse Max Potential First Input Delay 🟥 2,340 ms 🟥 1,710 ms ↓ −26.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 116 KiB 🟥 Potential savings of 102 KiB ↓ −23.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 609 KiB 🟥 Potential savings of 590 KiB ↓ −19.4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 96 KiB 🟥 Potential savings of 97 KiB ↓ −36.2 %
Lighthouse Server Backend Latencies 🟩 150 ms 🟩 30 ms ↓ −79 %
Lighthouse Initial server response time was short 🟩 Root document took 440 ms 🟩 Root document took 540 ms ↑ +24.2 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 80 ms ↑ +133.9 %
Lighthouse Cumulative Layout Shift 🟩 0.001 🟩 0 ↓ −100 %

588 other audits are unchanged.

@BioPhoton BioPhoton changed the title chore: add env var helper chore: add plugin targets Aug 12, 2025
@github-actions github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Aug 12, 2025
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Aug 13, 2025
@BioPhoton BioPhoton marked this pull request as ready for review August 14, 2025 11:19
@BioPhoton BioPhoton requested a review from matejchalk August 14, 2025 11:22
@github-actions github-actions bot removed 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin labels Aug 16, 2025
Copy link

nx-cloud bot commented Aug 21, 2025

View your CI Pipeline Execution ↗ for commit 1a44ce0

Command Status Duration Result
nx code-pushup --nx-bail -- print-config --verb... ❌ Failed 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-25 19:05:51 UTC

@github-actions github-actions bot added the 🔬 testing writing tests label Aug 22, 2025
@github-actions github-actions bot removed the 🔬 testing writing tests label Aug 22, 2025
matejchalk
matejchalk previously approved these changes Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants