-
Notifications
You must be signed in to change notification settings - Fork 16
chore: add standalone target with plugin caching #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BioPhoton
wants to merge
71
commits into
main
Choose a base branch
from
add-plugin-targets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/models
@code-pushup/core
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 276ddd6 with previous commit b08a9a7. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 4 audits regressed, 15 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
588 other audits are unchanged. |
# Conflicts: # code-pushup.config.ts
View your CI Pipeline Execution ↗ for commit 1a44ce0
☁️ Nx Cloud last updated this comment at |
BioPhoton
commented
Aug 22, 2025
matejchalk
previously approved these changes
Aug 25, 2025
# Conflicts: # nx.json
# Conflicts: # code-pushup.preset.ts # nx.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of:
Precondition:
unit-test
andint-test
targets #1061This PR includes:
add helper to load envVarsnx.json
defaultTargets
for main and plugincode-pushup
targetsaffected
and--parallel=3
readCachedProjectGraph
to avoid problems when running plugins in parallelNote
I cache the
js-packges
plugin target, against our discussion, as only in this PR I would have saved ~4minFollowup Todos:
zod2md.ts
undertools
and leverage"!{projectRoot}/tools/**/*"
innx.json#namedInputs.production
nx-plugin/mock
tomodels/mocks
and adjust inputsnx.json#targetDefaults
plugin-eslint
confignx run test-nx-utils:unit-test
is executed ATMnx.json#defaultTargets[N].@nx/vite:test
as empty ({}
) target is removedFollowup PRs: