Fix bugs in migration script #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
approved these changes
Jul 5, 2023
epicfaace
approved these changes
Jul 10, 2023
|
There is still another thing that needs to be fixed: If a user first uploads a bundle to Azure Blob storage and changes the database pointing to Azure Blob storage, then the user re-runs the script to delete the original bundle storage, the script can not find the original bundle location. Since we migrate step by step, we need to store state information somewhere. Possible solution: Working on this. |
AndrewJGaut
reviewed
Sep 10, 2023
…ed even though they weren't linked. 2) remove dependency on a file to determine which bundles to delete and what their original locations were.
epicfaace
added a commit
that referenced
this pull request
Oct 18, 2023
This reverts commit 73b4d7e.
epicfaace
added a commit
that referenced
this pull request
Oct 26, 2023
* Revert "Fix bugs in migration script (#4501)" This reverts commit 73b4d7e. * Only keeps migration.py changes. --------- Co-authored-by: Hidy Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
After testing on dev environment, we find more bugs in migration script.
Related issues
Screenshots
Checklist