Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code size: strip XR relevant code by USE_XR constants #18321

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

dumganhar
Copy link
Contributor

Re: #18222

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo February 12, 2025 11:05
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

👍 Package size ⤵ -2579 bytes, old: 5193364, new: 5190785

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL BuildTimeConstantsTest,SkewTest
ios PASS PASS FAIL reflection-probe,BuildTimeConstantsTest
mac PASS PASS FAIL reflection-probe,BuildTimeConstantsTest

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL BuildTimeConstantsTest
android PASS PASS FAIL BuildTimeConstantsTest
wechatgame PASS PASS FAIL SkewTest,BuildTimeConstantsTest

@minggo
Copy link
Contributor

minggo commented Feb 13, 2025

When is USE_XR true?

@dumganhar
Copy link
Contributor Author

WeChatc54d1c2dd951044029feebc0d74f29a2

When select xr feature in feature cropping configuration panel.

@minggo minggo merged commit 8791443 into cocos:v3.8.6 Feb 13, 2025
12 checks passed
dumganhar added a commit to dumganhar/cocos-engine that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants