Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed use labelShadow not setting contentSize correctly #18293

Closed
wants to merge 1 commit into from

Conversation

haiyoucuv
Copy link

Re: # Fixed use labelShadow not setting contentSize correctly

Changelog

  • cocos/2d/assembler/label/text-processing.ts

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@haiyoucuv
Copy link
Author

haiyoucuv commented Feb 7, 2025

Fixed use labelShadow not setting contentSize correctly
修复了使用labelShadow后contentSize没有设置到正确的值导致文字显示变形的问题

Before(修复前):
修复前

After(修复后):
修复后

Before with large value(修复前,使用极端值):
极端值修复前

After with large value(修复后,使用极端值):
极端值修复后

Copy link

github-actions bot commented Feb 7, 2025

👍 Package size ⤵ -24 bytes, old: 5195606, new: 5195582

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo requested a review from qiuguohua February 13, 2025 01:55
@qiuguohua
Copy link
Contributor

qiuguohua commented Feb 13, 2025

#17886
After internal discussion, we plan to implement a button to accommodate both effects in the future. One option will proportionally scale the content while maintaining the original size, fixing the font distortion issue.The other option will automatically expand the contentSize, as described in your PR.
Currently, merging this PR might impact compatibility. Therefore, we will hold off on merging it for now.
我们内部讨论了下,我们后续会做个按钮来兼容这两种效果:
1、一种的在原有大小情况下,等比例缩放,修复字体变形的问题;
2、一种是你这个PR描述的那样,自动扩展contentSize。
目前这个PR如果合并,可能会影响兼容性。所以,暂时不合并。

@qiuguohua qiuguohua closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants