Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code size for 2d module. #18239

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

dumganhar
Copy link
Contributor

Re: #18222

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo January 22, 2025 14:32
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

👍 Package size ⤵ -2711 bytes, old: 5232321, new: 5229610

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -510,9 +510,9 @@
          * @en Add mask nesting.
          * @zh 添加mask嵌套。
          * @deprecated since v3.7.0, this is an engine private interface that will be removed in the future.
          */
-        pushMask(mask: any): void;
+        pushMask(mask: number): void;
         /**
          * @en clear stencil stage.
          * @zh 清空模板状态。
          * @deprecated since v3.7.0, this is an engine private interface that will be removed in the future.
@@ -61333,8 +61333,9 @@
             MODEL = 1,
             MIDDLEWARE = 2,
             SUB_NODE = 3
         }
+        /** @mangle */
         export class _cocos_2d_renderer_render_draw_info__RenderDrawInfo {
             protected _accId: number;
             protected _bufferId: number;
             protected _vertexOffset: number;
@@ -61393,8 +61394,9 @@
             STATIC = 0,
             DYNAMIC = 1,
             CROSSED = 2
         }
+        /** @mangle */
         export class _cocos_2d_renderer_render_entity__RenderEntity {
             protected _node: Node | null;
             protected _renderTransform: Node | null;
             protected _stencilStage: _cocos_2d_renderer_stencil_manager__Stage;
@@ -61657,8 +61659,9 @@
             PT_LEFT = 2,
             PT_BEVEL = 4,
             PT_INNERBEVEL = 8
         }
+        /** @mangle */
         export class _cocos_2d_assembler_graphics_webgl_impl__Impl {
             dataOffset: number;
             updatePathOffset: boolean;
             pathLength: number;

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

@minggo minggo merged commit 1f67480 into cocos:v3.8.6 Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants