fix: show continuous stats during batch updates #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kindly review it and let me know for any changes thanks! |
georgeh0
reviewed
Oct 21, 2025
src/execution/live_updater.rs
Outdated
Comment on lines
349
to
356
| if delta.has_any_change() { | ||
| // Print periodic progress (do NOT merge here, final report_stats will merge) | ||
| println!( | ||
| "{}.{} ({update_title_owned}): {}", | ||
| flow_name, import_op_name, delta | ||
| ); | ||
| last_stats = current_stats; | ||
| } |
There was a problem hiding this comment.
Is it possible to always show the latest stats (instead of the delta), and keep overwriting the stats line showing before? For users, they always see the last line showing the current stats.
Did a brief research, and indicatif crate seems good for this purpose.
There was a problem hiding this comment.
got it wil check and apply the changes
There was a problem hiding this comment.
Screen.Recording.2025-10-21.at.6.30.13.PM.mov
is this right?
There was a problem hiding this comment.
That's awesome! Thanks!
Please push your commits.
thisisharsh7
force-pushed
the
fix/continuous-stats-reporting
branch
from
9c72aa6 to
c002510
Compare
|
please check and lmk for any updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #939
Problem
Previously, when running
cocoindex update, stats about processed documents were only printed once a full processing pass completed. For long-running updates, users had no visibility into ongoing progress, making it unclear if the process was still working.Solution
Implemented continuous stats reporting by spawning a background task.
Example Output