Skip to content

Add docs for leader-leaseholder splits #19755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-13920

@rmloveland rmloveland requested a review from miraradeva June 11, 2025 19:09
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 1cf3329
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6855a2007038dd00080d84cc

Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 1cf3329
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6855a2000f405200083db60a

@rmloveland
Copy link
Contributor Author

hi @miraradeva i hope PR this captures the gist of our convo (which i copied to the linked docs ticket)

but please let me know if i'm missing some important information, or if anything is incorrect

Copy link

@miraradeva miraradeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, thanks!

Copy link

netlify bot commented Jun 11, 2025

Netlify Preview

Name Link
🔨 Latest commit 1cf3329
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6855a2009752c50008f08f27
😎 Deploy Preview https://deploy-preview-19755--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland
Copy link
Contributor Author

rmloveland commented Jun 17, 2025

Look great, thanks!

thanks @miraradeva ! I have made updates based on your feedback in 7c1d5cf, thank you for the review!

i will move this along for docs team review to get it published ASAP

@rmloveland rmloveland requested a review from taroface June 17, 2025 15:56
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple suggestions

Fixes DOC-13920

NB. These changes are applied to v25.2, v25.3
@rmloveland rmloveland force-pushed the 20250611-DOC-13920-leader-leaseholder-split branch from a58f580 to 2abc535 Compare June 20, 2025 15:36
@rmloveland
Copy link
Contributor Author

thanks for the reviews!

i will now rebase on main and port these changes to v25.3 docs as well

@rmloveland rmloveland enabled auto-merge (squash) June 20, 2025 15:38
@rmloveland rmloveland merged commit 61376d6 into main Jun 20, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250611-DOC-13920-leader-leaseholder-split branch June 20, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants