-
Notifications
You must be signed in to change notification settings - Fork 470
Add docs for leader-leaseholder splits #19755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
hi @miraradeva i hope PR this captures the gist of our convo (which i copied to the linked docs ticket) but please let me know if i'm missing some important information, or if anything is incorrect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, thanks!
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
thanks @miraradeva ! I have made updates based on your feedback in 7c1d5cf, thank you for the review! i will move this along for docs team review to get it published ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple suggestions
Fixes DOC-13920 NB. These changes are applied to v25.2, v25.3
a58f580
to
2abc535
Compare
thanks for the reviews! i will now rebase on |
Fixes DOC-13920