-
Notifications
You must be signed in to change notification settings - Fork 469
Update diagnostics page re: telemetry info #19620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update diagnostics page re: telemetry info #19620
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
@kevin-v-ngo adding you to review so you're informed, not sure if this needs review beyond @jaiayu since we discussed on Slack a bit but y'all please let me know! |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
@jaiayu what do you think of this one? happy to update if you have any feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmloveland! LGTM! Just had one question on the frequency of reporting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple suggestions. I only added these to 23.1, but they apply across versions.
Fixes DOC-13703 Summary of changes: - Replace mentions of 'anonymous' with 'obfuscated/redacted' - Remove mention of some details, and point users to the 'Telemetry Collected by CockroachDB' page, which is intended to be the comprehensive reference - Replace 'hourly' with 'periodic' updates so we don't have to keep touching this NB. Applied these changes to all supported versions v23.1+
49ed2cb
to
c1a8d44
Compare
Fixes DOC-13703
Summary of changes:
Replace mentions of 'anonymous' with 'obfuscated/redacted'
Remove mention of details, and point users to the 'Telemetry Collected by CockroachDB' page, which is intended to be the comprehensive reference