Skip to content

Update diagnostics page re: telemetry info #19620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-13703

Summary of changes:

  • Replace mentions of 'anonymous' with 'obfuscated/redacted'

  • Remove mention of details, and point users to the 'Telemetry Collected by CockroachDB' page, which is intended to be the comprehensive reference

@rmloveland rmloveland requested review from kevin-v-ngo and jaiayu May 20, 2025 16:04
Copy link

netlify bot commented May 20, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit c1a8d44
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/684c9241fd043600085ad062

Copy link

netlify bot commented May 20, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit c1a8d44
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/684c92414c6b5b00086b8e24

@rmloveland
Copy link
Contributor Author

@kevin-v-ngo adding you to review so you're informed, not sure if this needs review beyond @jaiayu since we discussed on Slack a bit but y'all please let me know!

Copy link

netlify bot commented May 20, 2025

Netlify Preview

Name Link
🔨 Latest commit c1a8d44
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/684c92418287f8000847aa88
😎 Deploy Preview https://deploy-preview-19620--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland
Copy link
Contributor Author

@jaiayu what do you think of this one? happy to update if you have any feedback

Copy link

@jaiayu jaiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmloveland! LGTM! Just had one question on the frequency of reporting

@rmloveland rmloveland requested a review from taroface June 10, 2025 19:59
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple suggestions. I only added these to 23.1, but they apply across versions.

Fixes DOC-13703

Summary of changes:

- Replace mentions of 'anonymous' with 'obfuscated/redacted'

- Remove mention of some details, and point users to the 'Telemetry
  Collected by CockroachDB' page, which is intended to be the
  comprehensive reference

- Replace 'hourly' with 'periodic' updates so we don't have to keep
  touching this

NB. Applied these changes to all supported versions v23.1+
@rmloveland rmloveland force-pushed the 20250520-DOC-13703-update-diagnostics-reporting branch from 49ed2cb to c1a8d44 Compare June 13, 2025 21:03
@rmloveland rmloveland enabled auto-merge (squash) June 13, 2025 21:05
@rmloveland rmloveland merged commit 54f73da into main Jun 13, 2025
7 checks passed
@rmloveland rmloveland deleted the 20250520-DOC-13703-update-diagnostics-reporting branch June 13, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants